Add transitive typecheck output group

Author: MichaelMitchell-at

ts/defs.bzl

@@ -370,7 +370,9 @@ def ts_project(
     if not emit_tsc_js or not emit_tsc_dts:
         types_target_name = "%s_types" % name
         typecheck_target_name = "%s_typecheck" % name
+        transitive_typecheck_target_name = "%s_transitive_typecheck" % name
         test_target_name = "%s_typecheck_test" % name
+        transitive_typecheck_test_target_name = "%s_transitive_typecheck_test" % name
 
         # Users should build this target to get typing files
         if not no_emit:
@@ -397,6 +399,14 @@ def ts_project(
             **common_kwargs
         )
 
+        # Users should build this target to get a failed build when typechecking fails
+        native.filegroup(
+            name = transitive_typecheck_target_name,
+            srcs = [name],
+            output_group = "transitive_typecheck",
+            **common_kwargs
+        )
+
         # Ensures the typecheck target gets built under `bazel test --build_tests_only`
         build_test(
             name = test_target_name,
@@ -406,6 +416,14 @@ def ts_project(
             visibility = common_kwargs.get("visibility"),
         )
 
+        build_test(
+            name = transitive_typecheck_test_target_name,
+            targets = [transitive_typecheck_target_name],
+            tags = common_kwargs.get("tags"),
+            size = "small",
+            visibility = common_kwargs.get("visibility"),
+        )
+
     # Disable workers if a custom tsc was provided but not a custom tsc_worker.
     if tsc != _tsc and tsc_worker == _tsc_worker:
         supports_workers = 0

ts/private/ts_project.bzl

@@ -29,6 +29,15 @@ def _gather_types_from_js_infos(targets):
     ])
     return depset([], transitive = files_depsets)
 
+def _gather_transitive_typecheck_from_output_group_infos(typecheck_outs, targets):
+    files_depsets = []
+    files_depsets.extend([
+        target[OutputGroupInfo].transitive_typecheck
+        for target in targets
+        if OutputGroupInfo in target and "transitive_typecheck" in target[OutputGroupInfo]
+    ])
+    return depset(typecheck_outs, transitive = files_depsets)
+
 def _ts_project_impl(ctx):
     """Creates the action which spawns `tsc`.
 
@@ -308,6 +317,8 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
 
     transitive_types = js_lib_helpers.gather_transitive_types(output_types, srcs_tsconfig_deps)
 
+    transitive_typecheck = _gather_transitive_typecheck_from_output_group_infos(typecheck_outs, ctx.attr.deps)
+
     npm_sources = js_lib_helpers.gather_npm_sources(
         srcs = ctx.attr.srcs + [ctx.attr.tsconfig],
         deps = ctx.attr.deps,
@@ -345,6 +356,7 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
         OutputGroupInfo(
             types = output_types_depset,
             typecheck = depset(typecheck_outs),
+            transitive_typecheck = transitive_typecheck,
             # make the inputs to the tsc action available for analysis testing
             _action_inputs = transitive_inputs_depset,
             # https://bazel.build/extending/rules#validations_output_group