fix: rootdir calculation was still incorrect

In the case of a non-ts input, we still added a bazel-out/arch/bin segment to rootdir, which is wrong since that's the working dir

Author: alexeagle

examples/json/BUILD.bazel

@@ -0,0 +1,12 @@
+load("@aspect_rules_ts//ts:defs.bzl", "ts_project")
+
+# Demonstrates the --resolveJsonModule feature of TypeScript
+ts_project(
+    name = "ts",
+    srcs = [
+        "data.json",
+        "index.ts",
+    ],
+    out_dir = "build",
+    resolve_json_module = True,
+)

examples/json/data.json

@@ -0,0 +1,5 @@
+[
+    {
+        "a": "b"
+    }
+]

examples/json/index.ts

@@ -0,0 +1,2 @@
+import data from './data.json'
+export const a: string = 'hello' + JSON.stringify(data)

examples/json/tsconfig.json

@@ -0,0 +1,9 @@
+{
+    "compilerOptions": {
+        "esModuleInterop": true,
+        "resolveJsonModule": true,
+        // we can't use the current directory as outDir, because typescript wants to write a data.json file
+        // and that would collide with the source file we pass it.
+        "outDir": "build"
+    }
+}

ts/private/ts_lib.bzl

@@ -211,21 +211,7 @@ def _calculate_typing_maps_outs(srcs, typings_out_dir, root_dir, declaration_map
     return _out_paths(srcs, typings_out_dir, root_dir, allow_js, exts)
 
 def _calculate_root_dir(ctx):
-    root_path = None
-
-    # Note we don't have access to the ts_project macro allow_js param here.
-    # For error-handling purposes, we can assume that any .js/.jsx
-    # input is meant to be in the rootDir alongside .ts/.tsx sources,
-    # whether the user meant for them to be sources or not.
-    # It's a non-breaking change to relax this constraint later, but would be
-    # a breaking change to restrict it further.
-    allow_js = True
-    for src in ctx.files.srcs:
-        if not _is_ts_src(src.path, allow_js):
-            root_path = ctx.bin_dir.path
-
     return _join(
-        root_path,
         ctx.label.workspace_root,
         ctx.label.package,
         ctx.attr.root_dir,