chore: add bazel8 testing on ci

Author: jbedard

.aspect/bazelrc/correctness.bazelrc

@@ -42,17 +42,6 @@ test --incompatible_exclusive_test_sandboxed
 # Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_strict_action_env
 build --incompatible_strict_action_env
 
-# Propagate tags from a target declaration to the actions' execution requirements.
-# Ensures that tags applied in your BUILD file, like `tags=["no-remote"]`
-# get propagated to actions created by the rule.
-# Without this option, you rely on rules authors to manually check the tags you passed
-# and apply relevant ones to the actions they create.
-# See https://github.com/bazelbuild/bazel/issues/8830 for details.
-# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_allow_tags_propagation
-build --experimental_allow_tags_propagation
-fetch --experimental_allow_tags_propagation
-query --experimental_allow_tags_propagation
-
 # Do not automatically create `__init__.py` files in the runfiles of Python targets. Fixes the wrong
 # default that comes from Google's internal monorepo by using `__init__.py` to delimit a Python
 # package. Precisely, when a `py_binary` or `py_test` target has `legacy_create_init` set to `auto (the

.aspect/bazelrc/performance.bazelrc

@@ -5,14 +5,6 @@
 # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
 build --experimental_reuse_sandbox_directories
 
-# Do not build runfiles symlink forests for external repositories under
-# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
-# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
-# default in the future. Note, some rules may fail under this flag, please file issues with the rule
-# author.
-# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
-build --nolegacy_external_runfiles
-
 # Avoid creating a runfiles tree for binaries or tests until it is needed.
 # Docs: https://bazel.build/reference/command-line-reference#flag--build_runfile_links
 # See https://github.com/bazelbuild/bazel/issues/6627

.bazelrc

@@ -14,11 +14,6 @@ common --@aspect_rules_ts//ts:default_to_tsc_transpiler
 # opt-in to flag that is on by default in Bazel 8
 common --incompatible_disallow_empty_glob
 
-# Never Compile protoc Again
-common --incompatible_enable_proto_toolchain_resolution
-common --per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
-common --host_per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
-
 # verbose
 common:verbose --@aspect_rules_ts//ts:verbose --worker_verbose
 

.github/workflows/BUILD.bazel

@@ -6,5 +6,6 @@ write_aspect_bazelrc_presets(
         # Modified from upstream
         # "bazel6",
         "bazel7",
+        "bazel8",
     ],
 )

.github/workflows/bazel6.bazelrc

@@ -34,5 +34,24 @@ query --noexperimental_check_output_files
 # in Bazel 8.
 build --incompatible_remote_results_ignore_disk
 
+# Propagate tags from a target declaration to the actions' execution requirements.
+# Ensures that tags applied in your BUILD file, like `tags=["no-remote"]`
+# get propagated to actions created by the rule.
+# Without this option, you rely on rules authors to manually check the tags you passed
+# and apply relevant ones to the actions they create.
+# See https://github.com/bazelbuild/bazel/issues/8830 for details.
+# Docs: https://bazel.build/reference/command-line-reference#flag--experimental_allow_tags_propagation
+build --experimental_allow_tags_propagation
+fetch --experimental_allow_tags_propagation
+query --experimental_allow_tags_propagation
+
+# Do not build runfiles symlink forests for external repositories under
+# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
+# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
+# default in the future. Note, some rules may fail under this flag, please file issues with the rule
+# author.
+# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
+build --nolegacy_external_runfiles
+
 # Added in 6.4.0, see https://github.com/bazelbuild/bazel/pull/19319
 build --incompatible_merge_fixed_and_default_shell_env

.github/workflows/bazel7.bazelrc

@@ -13,3 +13,11 @@ common --check_direct_dependencies=off
 # build.
 # Docs: https://bazel.build/reference/command-line-reference#flag--reuse_sandbox_directories
 build --reuse_sandbox_directories
+
+# Do not build runfiles symlink forests for external repositories under
+# `.runfiles/wsname/external/repo` (in addition to `.runfiles/repo`). This reduces runfiles &
+# sandbox creation times & prevents accidentally depending on this feature which may flip to off by
+# default in the future. Note, some rules may fail under this flag, please file issues with the rule
+# author.
+# Docs: https://bazel.build/reference/command-line-reference#flag--legacy_external_runfiles
+build --nolegacy_external_runfiles

.github/workflows/bazel8.bazelrc

@@ -0,0 +1 @@
+# No Bazel 8 specific flag presets yet.

.github/workflows/ci.yaml

@@ -30,6 +30,7 @@ jobs:
                   m=${v::1}
                   a=(
                     "major:$m, version:\"$v\""
+                    "major:8, version:\"8.3.1\""
                     "major:6, version:\"6.5.0\""
                   )
                   printf -v j '{%s},' "${a[@]}"
@@ -93,6 +94,9 @@ jobs:
                     - bazel-version:
                           major: 6
                       bzlmod: 0
+                    # Don't run tests with Bazel 8 by default
+                    - bazel-version:
+                          major: 8
                     # Don't test root workspace with non-bzlmod
                     - bzlmod: 0
                       folder: .
@@ -113,6 +117,14 @@ jobs:
                       bzlmod: 1
                       folder: docs
                       os: ubuntu
+
+                    # Include only unit tests with bazel8
+                    - bazel-version:
+                          major: 8
+                      bzlmod: 1
+                      folder: .
+                      os: ubuntu
+
         # Steps represent a sequence of tasks that will be executed as part of the job
         steps:
             # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
@@ -179,6 +191,8 @@ jobs:
                 exclude:
                     - bazel-version:
                           major: 6
+                    - bazel-version:
+                          major: 8
         steps:
             - uses: actions/checkout@v4
 

MODULE.bazel

@@ -7,7 +7,7 @@ module(
 )
 
 # Lower-bounds (minimum) versions for direct runtime dependencies
-bazel_dep(name = "aspect_bazel_lib", version = "2.9.3")
+bazel_dep(name = "aspect_bazel_lib", version = "2.14.0")
 bazel_dep(name = "aspect_rules_js", version = "2.0.0")
 bazel_dep(name = "bazel_skylib", version = "1.8.1")
 bazel_dep(name = "platforms", version = "0.0.5")

docs/.bazelrc

@@ -1,5 +0,0 @@
-# Never Compile protoc Again
-# Don't build protoc from the cc_binary, it's slow and spammy when cache miss
-common --per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
-common --host_per_file_copt=external/.*protobuf.*@--PROTOBUF_WAS_NOT_SUPPOSED_TO_BE_BUILT
-common --java_runtime_version=remotejdk_11