Skip to content

Commit d82b64b

Browse files
authored
fix: rename LATEST_VERSION to LATEST_TYPESCRIPT_VERSION (#354)
The previous name is left for backwards compatibility and will be removed in v2.0. Fix aspect-build/rules_js#817
1 parent be02df9 commit d82b64b

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

e2e/external_dep/WORKSPACE

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ local_repository(
55
path = "../..",
66
)
77

8-
load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
9-
rules_ts_dependencies(ts_version = LATEST_VERSION)
8+
load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_TYPESCRIPT_VERSION", "rules_ts_dependencies")
9+
10+
rules_ts_dependencies(ts_version = LATEST_TYPESCRIPT_VERSION)
1011

1112
# Fetch and register node, if you haven't already
1213
load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

e2e/external_dep/app/WORKSPACE

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,15 @@ local_repository(
22
name = "aspect_rules_ts",
33
path = "../../..",
44
)
5+
56
local_repository(
67
name = "lib_wksp",
78
path = "..",
89
)
910

10-
load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION", "rules_ts_dependencies")
11-
rules_ts_dependencies(ts_version = LATEST_VERSION)
11+
load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_TYPESCRIPT_VERSION", "rules_ts_dependencies")
12+
13+
rules_ts_dependencies(ts_version = LATEST_TYPESCRIPT_VERSION)
1214

1315
# Fetch and register node, if you haven't already
1416
load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")

e2e/workspace/WORKSPACE

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ rules_ts_dependencies(
2121
ts_version_from = "//:package.json",
2222

2323
# Alternatively, you could pick a specific version, or use
24-
# load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_VERSION")
25-
# ts_version = LATEST_VERSION
24+
# load("@aspect_rules_ts//ts:repositories.bzl", "LATEST_TYPESCRIPT_VERSION")
25+
# ts_version = LATEST_TYPESCRIPT_VERSION
2626
)
2727

2828
# Fetch and register node, if you haven't already

ts/extensions.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ See https://bazel.build/docs/bzlmod#extension-definition
33
"""
44

55
load("//ts/private:npm_repositories.bzl", "npm_dependencies")
6-
load("//ts:repositories.bzl", "LATEST_VERSION")
6+
load("//ts:repositories.bzl", "LATEST_TYPESCRIPT_VERSION")
77

88
def _extension_impl(module_ctx):
99
for mod in module_ctx.modules:
@@ -13,6 +13,6 @@ def _extension_impl(module_ctx):
1313
ext = module_extension(
1414
implementation = _extension_impl,
1515
tag_classes = {
16-
"deps": tag_class(attrs = {"ts_version": attr.string(default = LATEST_VERSION), "ts_integrity": attr.string()}),
16+
"deps": tag_class(attrs = {"ts_version": attr.string(default = LATEST_TYPESCRIPT_VERSION), "ts_integrity": attr.string()}),
1717
},
1818
)

ts/repositories.bzl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ load("//ts/private:maybe.bzl", http_archive = "maybe_http_archive")
88
load("//ts/private:npm_repositories.bzl", "npm_dependencies")
99
load("//ts/private:versions.bzl", "TOOL_VERSIONS")
1010

11-
LATEST_VERSION = TOOL_VERSIONS.keys()[-1]
11+
LATEST_TYPESCRIPT_VERSION = TOOL_VERSIONS.keys()[-1]
12+
13+
# TODO(2.0): remove this alias
14+
LATEST_VERSION = LATEST_TYPESCRIPT_VERSION
1215

1316
# WARNING: any additions to this function may be BREAKING CHANGES for users
1417
# because we'll fetch a dependency which may be different from one that

0 commit comments

Comments
 (0)