Skip to content

Commit da5d96f

Browse files
authored
chore: update to rules_js 0.10.0 (#34)
1 parent 14367a7 commit da5d96f

File tree

8 files changed

+30
-31
lines changed

8 files changed

+30
-31
lines changed

WORKSPACE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ gazelle_dependencies()
4444

4545
###########################################
4646
# A pnpm workspace so we can test 3p deps
47-
load("@aspect_rules_js//js:npm_import.bzl", "translate_pnpm_lock")
47+
load("@aspect_rules_js//npm:npm_import.bzl", "translate_pnpm_lock")
4848

4949
translate_pnpm_lock(
5050
name = "npm",

examples/BUILD.bazel

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
load("@npm//:defs.bzl", "link_js_packages")
2-
load("@aspect_rules_js//js:defs.bzl", "link_js_package")
1+
load("@npm//:defs.bzl", "link_all_npm_packages")
2+
load("@aspect_rules_js//npm:defs.bzl", "link_npm_package")
33

44
# Building this target results in bazel-bin/examples/node_modules/@myorg/js_lib, so that
55
# TypeScript and other node programs beneath bazel-bin/examples are able to resolve its location.
6-
link_js_package(
7-
name = "link_js_lib",
6+
link_npm_package(
7+
name = "node_modules/@myorg/js_lib",
88
src = "//examples/js_lib",
99
root_package = "examples",
1010
visibility = ["//examples:__subpackages__"],
1111
)
1212

13-
# This macro expands to a link_js_package for each third-party package in package.json
14-
link_js_packages()
13+
# This macro expands to a link_npm_package for each third-party package in package.json
14+
link_all_npm_packages(name = "node_modules")

examples/js_lib/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
load("@aspect_rules_js//js:defs.bzl", "js_package")
1+
load("@aspect_rules_js//npm:defs.bzl", "npm_package")
22

3-
js_package(
3+
npm_package(
44
name = "js_lib",
55
srcs = ["index.js"],
66
package = "@myorg/js_lib",

examples/simple/BUILD.bazel

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,8 @@ load("@bazel_skylib//rules:write_file.bzl", "write_file")
33

44
# Dependencies for all targets in this package
55
_DEPS = [
6-
# For packages within the workspace, we use the link target in the node_modules tree:
7-
"//examples:link_js_lib",
8-
# Third-party packages from npm can be referenced directly:
9-
"@npm//examples/@types/node",
6+
"//examples:node_modules/@myorg/js_lib",
7+
"//examples:node_modules/@types/node",
108
]
119

1210
# Type-checks, and emits output to

examples/transpiler/babel.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def babel(name, srcs, js_outs, map_outs, **kwargs):
3232
name = "{}_{}".format(name, idx),
3333
srcs = [
3434
src,
35-
"@npm//examples/@babel/preset-typescript",
35+
"//examples:node_modules/@babel/preset-typescript",
3636
],
3737
chdir = "examples",
3838
outs = outs,

internal_deps.bzl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ def rules_ts_internal_deps():
6666
maybe(
6767
http_archive,
6868
name = "aspect_rules_swc",
69-
sha256 = "78f0f4a8916c52d1a46b3885129ac04fdad5e4c0fb454255ada2cf04ef7f0f04",
70-
strip_prefix = "rules_swc-0.8.0",
71-
url = "https://github.com/aspect-build/rules_swc/archive/refs/tags/v0.8.0.tar.gz",
69+
sha256 = "24df246060f39294e3a4f8b9759d3e9cc382d01ddf8926beb5221992af194bc0",
70+
strip_prefix = "rules_swc-0.9.0",
71+
url = "https://github.com/aspect-build/rules_swc/archive/refs/tags/v0.9.0.tar.gz",
7272
)

ts/BUILD.typescript

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,31 @@
11
"BUILD file inserted into @npm_typescript repository"
2-
load("@aspect_rules_js//js:defs.bzl", "constants", "link_js_package", "js_package", "js_binary")
2+
load("@aspect_rules_js//js:defs.bzl", "js_binary")
3+
load("@aspect_rules_js//npm:defs.bzl", "link_npm_package", "npm_package")
34
load("@aspect_bazel_lib//lib:directory_path.bzl", "directory_path")
45
load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
56
load("@bazel_skylib//rules:write_file.bzl", "write_file")
67

7-
js_package(
8-
name = "_npm_typescript",
8+
npm_package(
9+
name = "npm_typescript",
910
src = "package",
1011
package = "typescript",
1112
)
1213

13-
link_js_package(
14-
name = "npm_typescript",
15-
src = "_npm_typescript",
14+
link_npm_package(
15+
name = "node_modules/typescript",
16+
src = "npm_typescript",
1617
visibility = ["//visibility:public"],
1718
)
1819

1920
directory_path(
2021
name = "tsc_entrypoint",
21-
directory = ":npm_typescript{}".format(constants.dir_suffix),
22+
directory = ":node_modules/typescript/dir",
2223
path = "bin/tsc",
2324
)
2425

2526
js_binary(
2627
name = "tsc",
27-
data = [":npm_typescript"],
28+
data = [":node_modules/typescript"],
2829
entry_point = ":tsc_entrypoint",
2930
visibility = ["//visibility:public"],
3031
)
@@ -37,7 +38,7 @@ copy_file(
3738

3839
js_binary(
3940
name = "validator",
40-
data = ["npm_typescript"],
41+
data = [":node_modules/typescript"],
4142
entry_point = "copy_validator",
4243
visibility = ["//visibility:public"],
4344
)

ts/repositories.bzl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
99
load("//ts/private:versions.bzl", TS_VERSIONS = "VERSIONS")
1010

1111
versions = struct(
12-
bazel_lib = "0.11.1",
12+
bazel_lib = "0.12.1",
1313
rules_nodejs = "5.4.0",
1414
rules_js = "0.9.1",
1515
)
@@ -107,15 +107,15 @@ def rules_ts_dependencies(ts_version_from = None, ts_version = None, ts_integrit
107107
maybe(
108108
http_archive,
109109
name = "aspect_rules_js",
110-
sha256 = "f01010e1f6bd49a8da6f7350c60992b7eb2eb62058cfe7aa6abd9e416bc2158b",
111-
strip_prefix = "rules_js-" + versions.rules_js,
112-
url = "https://github.com/aspect-build/rules_js/archive/refs/tags/v{}.tar.gz".format(versions.rules_js),
110+
sha256 = "2db66bedabc30f2dfa87bd4845e42b0dbc80fa9344d2dfbaa2685cdced2f1e03",
111+
strip_prefix = "rules_js-0.10.0",
112+
url = "https://github.com/aspect-build/rules_js/archive/refs/tags/v0.10.0.tar.gz",
113113
)
114114

115115
maybe(
116116
http_archive,
117117
name = "aspect_bazel_lib",
118-
sha256 = "a8b47eeaf3c1bd41c4f4b633ef4c959daf83fdee343379495098b50571d4b3b8",
118+
sha256 = "91aa7356b22ecdb87dcf5f1cc8a6a147e23a1ef425221bab75e5f857cd6b2716",
119119
strip_prefix = "bazel-lib-" + versions.bazel_lib,
120120
url = "https://github.com/aspect-build/bazel-lib/archive/refs/tags/v{}.tar.gz".format(versions.bazel_lib),
121121
)

0 commit comments

Comments
 (0)