Merge pull request #745 from jimmylewis/missingVersionError

Add an error when the manifest is missing a version

Author: phil-allen-msft

src/LibraryManager.Contracts/PredefinedErrors.cs

@@ -198,6 +198,12 @@ public static IError DuplicateLibrariesInManifest(string duplicateLibrary)
         public static IError FileNameMustNotBeEmpty(string libraryId)
             => new Error("LIB020", string.Format(Text.ErrorFilePathIsEmpty, libraryId));
 
+        /// <summary>
+        /// The manifest must specify a version
+        /// </summary>
+        public static IError MissingManifestVersion()
+            => new Error("LIB022", Text.ErrorMissingManifestVersion);
+
         /// <summary>
         /// Unknown error occurred
         /// </summary>

src/LibraryManager.Contracts/Resources/Text.Designer.cs

@@ -187,4 +187,7 @@ Valid files are {2}</value>
   <data name="ErrorFilePathIsEmpty" xml:space="preserve">
     <value>The library "{0}" cannot specify a file with an empty name</value>
   </data>
-</root>
+  <data name="ErrorMissingManifestVersion" xml:space="preserve">
+    <value>The Library Manager manifest must specify a version.</value>
+  </data>
+</root>

src/LibraryManager.Contracts/Resources/Text.resx

@@ -80,12 +80,17 @@ public static async Task<IEnumerable<ILibraryOperationResult>> GetManifestErrors
 
             if (manifest == null)
             {
-                return new ILibraryOperationResult[] { LibraryOperationResult.FromError(PredefinedErrors.ManifestMalformed()) };
+                return [LibraryOperationResult.FromError(PredefinedErrors.ManifestMalformed())];
+            }
+
+            if (string.IsNullOrEmpty(manifest.Version))
+            {
+                return [LibraryOperationResult.FromError(PredefinedErrors.MissingManifestVersion())];
             }
 
             if (!IsValidManifestVersion(manifest.Version))
             {
-                return new ILibraryOperationResult[] { LibraryOperationResult.FromError(PredefinedErrors.VersionIsNotSupported(manifest.Version)) };
+                return [LibraryOperationResult.FromError(PredefinedErrors.VersionIsNotSupported(manifest.Version))];
             }
 
             return await GetLibrariesErrorsAsync(manifest.Libraries, dependencies, manifest.DefaultDestination, manifest.DefaultProvider, cancellationToken);

src/LibraryManager/LibrariesValidator.cs

@@ -235,7 +235,7 @@ public async Task RestoreAsync_AllRestoreOperationsCancelled()
         }
 
         [TestMethod]
-        public async Task RestorAsync_ConflictingLibraries_Validate()
+        public async Task RestoreAsync_ConflictingLibraries_Validate()
         {
             var manifest = Manifest.FromJson(_docConflictingLibraries, _dependencies);
 
@@ -246,7 +246,7 @@ public async Task RestorAsync_ConflictingLibraries_Validate()
         }
 
         [TestMethod]
-        public async Task RestorAsync_ConflictingLibraries_Restore()
+        public async Task RestoreAsync_ConflictingLibraries_Restore()
         {
             var manifest = Manifest.FromJson(_docConflictingLibraries, _dependencies);
 
@@ -263,6 +263,19 @@ public void FromJson_Malformed()
             Assert.IsNull(manifest);
         }
 
+        [TestMethod]
+        public async Task FromJson_MissingManifestVersion()
+        {
+            var manifest = Manifest.FromJson("{}", _dependencies);
+
+            List<ILibraryOperationResult> result = (await manifest.GetValidationResultsAsync(CancellationToken.None)).ToList();
+
+            Assert.AreEqual(1, result.Count);
+            Assert.IsFalse(result[0].Success);
+            Assert.AreEqual(1, result[0].Errors.Count);
+            Assert.AreEqual("LIB022", result[0].Errors[0].Code);
+        }
+
         [TestMethod]
         public async Task FromFileAsync_FileNotFound()
         {