Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

Commit 0eaf154

Browse files
dougbudougbu
committed
Add more functional tests
- #180 part 1 of n - extend first (Dropbox) functional tests - rename test class to match sample project; now `DropboxCoreReceiverTest` - add `DropboxCoreReceiverTest.WebHookAction_NonGetOrPost_IsNotAllowed(...)` - prepare other (non-Dropbox) samples for functional testing - target frameworks specified in `$(StandardTestWebsiteTfms)` property - refactor `Program`s to meet Mvc.Testing expectations - add default secret key to appsettings.json files; add this file if necessary - fix BitbucketStronglyTypedCoreReceiver to compile with .NET 4.6.1 and to run validations - add functional tests of remaining (non-Dropbox) samples - does not yet include tests requiring a non-empty request body nits: VS removed some BOMs
1 parent 14ec5b1 commit 0eaf154

File tree

57 files changed

+1629
-138
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+1629
-138
lines changed

Diff for: ‎build/dependencies.props

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
<PropertyGroup Label="Package Versions">
77
<InternalAspNetCoreSdkPackageVersion>2.1.0-rc1-15774</InternalAspNetCoreSdkPackageVersion>
88
<MicrosoftAspNetCoreMvcCorePackageVersion>2.1.0-rc1-30613</MicrosoftAspNetCoreMvcCorePackageVersion>
9+
<MicrosoftAspNetCoreMvcDataAnnotationsPackageVersion>2.1.0-rc1-30613</MicrosoftAspNetCoreMvcDataAnnotationsPackageVersion>
910
<MicrosoftAspNetCoreMvcFormattersJsonPackageVersion>2.1.0-rc1-30613</MicrosoftAspNetCoreMvcFormattersJsonPackageVersion>
1011
<MicrosoftAspNetCoreMvcFormattersXmlPackageVersion>2.1.0-rc1-30613</MicrosoftAspNetCoreMvcFormattersXmlPackageVersion>
1112
<MicrosoftAspNetCoreMvcTestingPackageVersion>2.1.0-rc1-30613</MicrosoftAspNetCoreMvcTestingPackageVersion>

Diff for: ‎samples/AzureAlertCoreReceiver/AzureAlertCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/AzureAlertCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace AzureAlertCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/AzureAlertCoreReceiver/appsettings.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"WebHooks:AzureAlert:SecretKey:default": "01234567890123456789012345678901"
3+
}

Diff for: ‎samples/BitbucketCoreReceiver/BitbucketCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/BitbucketCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace BitbucketCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/BitbucketCoreReceiver/appsettings.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{
1+
{
2+
"WebHooks:Bitbucket:SecretKey:default": "01234567890123456789012345678901",
23
"Logging": {
34
"IncludeScopes": false,
45
"LogLevel": {
@@ -12,4 +13,4 @@
1213
}
1314
}
1415
}
15-
}
16+
}

Diff for: ‎samples/BitbucketStronglyTypedCoreReceiver/BitbucketStronglyTypedCoreReceiver.csproj

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>
77
<PackageReference Include="Microsoft.AspNetCore" Version="$(MicrosoftAspNetCorePackageVersion)" />
8+
<PackageReference Include="Microsoft.AspNetCore.Mvc.DataAnnotations" Version="$(MicrosoftAspNetCoreMvcDataAnnotationsPackageVersion)" />
89
<ProjectReference Include="..\..\src\Microsoft.AspNetCore.WebHooks.Receivers.BitBucket\Microsoft.AspNetCore.WebHooks.Receivers.BitBucket.csproj" />
910
</ItemGroup>
1011
</Project>

Diff for: ‎samples/BitbucketStronglyTypedCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace BitbucketStronglyTypedCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/BitbucketStronglyTypedCoreReceiver/Startup.cs

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore.Builder;
1+
using Microsoft.AspNetCore.Builder;
22
using Microsoft.AspNetCore.Hosting;
33
using Microsoft.Extensions.DependencyInjection;
44

@@ -12,7 +12,8 @@ public void ConfigureServices(IServiceCollection services)
1212
{
1313
services
1414
.AddMvcCore()
15-
.AddBitbucketWebHooks();
15+
.AddBitbucketWebHooks()
16+
.AddDataAnnotations();
1617
}
1718

1819
// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.

Diff for: ‎samples/BitbucketStronglyTypedCoreReceiver/appsettings.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{
1+
{
2+
"WebHooks:Bitbucket:SecretKey:default": "01234567890123456789012345678901",
23
"Logging": {
34
"IncludeScopes": false,
45
"LogLevel": {
@@ -12,4 +13,4 @@
1213
}
1314
}
1415
}
15-
}
16+
}

Diff for: ‎samples/DynamicsCRMCoreReceiver/DynamicsCRMCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/DynamicsCRMCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace DynamicsCRMCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/DynamicsCRMCoreReceiver/appsettings.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{
1+
{
2+
"WebHooks:DynamicsCrm:SecretKey:default": "01234567890123456789012345678901",
23
"Logging": {
34
"IncludeScopes": false,
45
"LogLevel": {
@@ -12,4 +13,4 @@
1213
}
1314
}
1415
}
15-
}
16+
}

Diff for: ‎samples/GitHubCoreReceiver/GitHubCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/GitHubCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace GitHubCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/GitHubCoreReceiver/appsettings.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"WebHooks:GitHub:SecretKey:default": "0123456789012345"
3+
}

Diff for: ‎samples/KuduCoreReceiver/KuduCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/KuduCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace KuduCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/KuduCoreReceiver/appsettings.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"WebHooks:Kudu:SecretKey:default": "01234567890123456789012345678901"
3+
}

Diff for: ‎samples/MailChimpCoreReceiver/MailChimpCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/MailChimpCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace MailChimpCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/MailChimpCoreReceiver/appsettings.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"WebHooks:MailChimp:SecretKey:default": "01234567890123456789012345678901"
3+
}

Diff for: ‎samples/PusherCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace PusherCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/PusherCoreReceiver/PusherCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/PusherCoreReceiver/appsettings.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{
1+
{
2+
"WebHooks:Pusher:SecretKey:default:theApplicationKey": "01234567",
23
"Logging": {
34
"IncludeScopes": false,
45
"LogLevel": {
@@ -12,4 +13,4 @@
1213
}
1314
}
1415
}
15-
}
16+
}

Diff for: ‎samples/SalesforceCoreReceiver/Program.cs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using Microsoft.AspNetCore;
1+
using Microsoft.AspNetCore;
22
using Microsoft.AspNetCore.Hosting;
33

44
namespace SalesforceCoreReceiver
@@ -7,12 +7,11 @@ public class Program
77
{
88
public static void Main(string[] args)
99
{
10-
BuildWebHost(args).Run();
10+
CreateWebHostBuilder(args).Build().Run();
1111
}
1212

13-
public static IWebHost BuildWebHost(string[] args) =>
13+
public static IWebHostBuilder CreateWebHostBuilder(string[] args) =>
1414
WebHost.CreateDefaultBuilder(args)
15-
.UseStartup<Startup>()
16-
.Build();
15+
.UseStartup<Startup>();
1716
}
1817
}

Diff for: ‎samples/SalesforceCoreReceiver/SalesforceCoreReceiver.csproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Project Sdk="Microsoft.NET.Sdk.Web">
22
<PropertyGroup>
3-
<TargetFramework>netcoreapp2.0</TargetFramework>
3+
<TargetFrameworks>$(StandardTestWebsiteTfms)</TargetFrameworks>
44
</PropertyGroup>
55

66
<ItemGroup>

Diff for: ‎samples/SalesforceCoreReceiver/appsettings.json

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
{
1+
{
2+
"WebHooks:Salesforce:SecretKey:default": "012345678901234",
23
"Logging": {
34
"IncludeScopes": false,
45
"LogLevel": {
@@ -12,4 +13,4 @@
1213
}
1314
}
1415
}
15-
}
16+
}

0 commit comments

Comments
 (0)