Only make diffImage when the images don't match. Closes #75

glibas · glibas · commit 7e442789c091 · 2020-06-30T11:53:25.000+01:00
diff --git a/src/main/java/com/assertthat/selenium_shutterbug/utils/image/model/ImageData.java b/src/main/java/com/assertthat/selenium_shutterbug/utils/image/model/ImageData.java
@@ -33,8 +33,11 @@ public boolean equalsEachPixelsWithCreateDifferencesImage(ImageData imageData, d
     }
 
     private boolean equalsEachPixelsWithCreateDifferencesImage(BufferedImage image, double deviation, String pathDifferenceImageFileName) {
-        createDifferencesImage(image, pathDifferenceImageFileName);
-        return equalsEachPixels(image, deviation);
+        boolean isEqual = equalsEachPixels(image, deviation);
+        if(!isEqual) {
+            createDifferencesImage(image, pathDifferenceImageFileName);
+        }
+        return isEqual;
     }
 
     private void createDifferencesImage(BufferedImage image, String pathDifferenceImageFileName) {

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,11 @@ public boolean equalsEachPixelsWithCreateDifferencesImage(ImageData imageData, d`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`private boolean equalsEachPixelsWithCreateDifferencesImage(BufferedImage image, double deviation, String pathDifferenceImageFileName) {`
`36`		`- createDifferencesImage(image, pathDifferenceImageFileName);`
`37`		`- return equalsEachPixels(image, deviation);`
	`36`	`+ boolean isEqual = equalsEachPixels(image, deviation);`
	`37`	`+ if(!isEqual) {`
	`38`	`+ createDifferencesImage(image, pathDifferenceImageFileName);`
	`39`	`+ }`
	`40`	`+ return isEqual;`
`38`	`41`	`}`
`39`	`42`
`40`	`43`	`private void createDifferencesImage(BufferedImage image, String pathDifferenceImageFileName) {`