Skip to content

Commit 432bcbe

Browse files
authored
Remove Windows artifacts with the -shared suffix (#554)
These are purely duplicative and were retained for a transition period.
1 parent 9f44755 commit 432bcbe

File tree

3 files changed

+5
-38
lines changed

3 files changed

+5
-38
lines changed

cpython-windows/build.py

+1-11
Original file line numberDiff line numberDiff line change
@@ -1801,22 +1801,12 @@ def main() -> None:
18011801
release_tag = release_tag_from_git()
18021802

18031803
# Create, e.g., `cpython-3.10.13+20240224-x86_64-pc-windows-msvc-pgo.tar.zst`.
1804-
dest_path = compress_python_archive(
1804+
compress_python_archive(
18051805
tar_path,
18061806
DIST,
18071807
"%s-%s" % (tar_path.stem, release_tag),
18081808
)
18091809

1810-
# Copy to, e.g., `cpython-3.10.13+20240224-x86_64-pc-windows-msvc-shared-pgo.tar.zst`.
1811-
# The 'shared-' prefix is no longer needed, but we're double-publishing under
1812-
# both names during the transition period.
1813-
filename: str = dest_path.name
1814-
if not filename.endswith("-%s-%s.tar.zst" % (args.options, release_tag)):
1815-
raise ValueError("expected filename to end with profile: %s" % filename)
1816-
filename = filename.removesuffix("-%s-%s.tar.zst" % (args.options, release_tag))
1817-
filename = filename + "-shared-%s-%s.tar.zst" % (args.options, release_tag)
1818-
shutil.copy2(dest_path, dest_path.with_name(filename))
1819-
18201810

18211811
if __name__ == "__main__":
18221812
sys.exit(main())

docs/running.rst

+4
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,8 @@ familiar with LLVM target triples, here is an overview:
4848
Python and extensions. These builds behave like the official Python
4949
for Windows distributions.
5050

51+
These builds are now published without the `-shared` suffix.
52+
5153
``*-windows-msvc-static``
5254
These builds of Python are statically linked.
5355

@@ -57,6 +59,8 @@ familiar with LLVM target triples, here is an overview:
5759

5860
See :ref:`quirk_windows_static_distributions` for more.
5961

62+
These builds are no longer published.
63+
6064
``x86_64-unknown-linux-gnu``
6165
Linux 64-bit Intel/AMD CPUs linking against GNU libc.
6266

src/release.rs

-27
Original file line numberDiff line numberDiff line change
@@ -130,33 +130,6 @@ pub static RELEASE_TRIPLES: Lazy<BTreeMap<&'static str, TripleRelease>> = Lazy::
130130
},
131131
);
132132

133-
// The 'shared-' prefix is no longer needed, but we're double-publishing under both names during
134-
// the transition period.
135-
h.insert(
136-
"i686-pc-windows-msvc-shared",
137-
TripleRelease {
138-
suffixes: vec!["pgo"],
139-
install_only_suffix: "pgo",
140-
python_version_requirement: None,
141-
conditional_suffixes: vec![ConditionalSuffixes {
142-
python_version_requirement: VersionSpecifier::from_str(">=3.13").unwrap(),
143-
suffixes: vec!["freethreaded+pgo"],
144-
}],
145-
},
146-
);
147-
h.insert(
148-
"x86_64-pc-windows-msvc-shared",
149-
TripleRelease {
150-
suffixes: vec!["pgo"],
151-
install_only_suffix: "pgo",
152-
python_version_requirement: None,
153-
conditional_suffixes: vec![ConditionalSuffixes {
154-
python_version_requirement: VersionSpecifier::from_str(">=3.13").unwrap(),
155-
suffixes: vec!["freethreaded+pgo"],
156-
}],
157-
},
158-
);
159-
160133
// Linux.
161134
let linux_suffixes_pgo = vec!["debug", "pgo+lto"];
162135
let linux_suffixes_nopgo = vec!["debug", "lto", "noopt"];

0 commit comments

Comments
 (0)