Skip to content

Commit 6c63bd9

Browse files
Use any merge strategy in the morning - link to the history section straight after lunch (MetOffice#71)
1 parent 266ecf1 commit 6c63bd9

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

episodes/04-review.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ you can approve the PR:
163163
Swap back to the Conversations tab.
164164
The PR is now ready to merge and has no conflicts with the
165165
base (`main` in this case) branch.
166-
Click **Squash and merge**; don't forget to move the PR
166+
Click any of the 3 merge options; don't forget to move the PR
167167
number to the start of the commit message like you did
168168
in the Version Control with Git lesson:
169169

@@ -269,6 +269,18 @@ Deleted branch 1_favourite_cloud (was b7f26e6).
269269

270270
::::::::::::::::::::::::::::::::::::::::::::::::::
271271

272+
::::::::::::::::::::::::::::::::::::::: challenge
273+
274+
## How was your PR merged?
275+
276+
In this episode you merged each others PRs.
277+
The reviewer used a random merge strategy to merge each PR.
278+
279+
Explore the history of the repository with `git log` and find your PR merge.
280+
How has the chosen merge strategy affected the repositories history?
281+
282+
::::::::::::::::::::::::::::::::::::::::::::::::::
283+
272284
:::::::::::::::::::::::::::::::::::::::: keypoints
273285

274286
- A Pull Request (PR) is where your code and science review takes place.

instructors/instructor-notes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,9 @@ watching the reviewer or the developer.
207207
Swap back to the first instructor so they can approve the changes.
208208
Make sure you cover the content in the
209209
**WHO PRESSES THE MERGE BUTTON?** callout.
210+
Learners can use any merge strategy here, you will use this as
211+
an opportunity to see the history in the next episode
212+
and suggest sticking to one.
210213
Give learners a break and the opportunity to complete
211214
the yellow challenge **Local Cleanup**.
212215

0 commit comments

Comments
 (0)