You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: episodes/04-review.md
+16Lines changed: 16 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -68,6 +68,7 @@ Click on the file icon or press <kbd>Ctrl+g</kbd>:
68
68
69
69
{alt='A screenshot of a PR showing the diff in the Files changed tab. A line has been highlighted to show how to add an inline comment with a suggestion.'}
70
70
71
+
Add in a suggested change for your review.
71
72
Click on the green **Start a review** button.
72
73
Now click on the green button in the top right which says
73
74
**Finish your review** or **Review Changes**,
@@ -100,6 +101,21 @@ and then marked the conversation with the suggested change as resolved.
100
101
Re-request a review by clicking on the two arrows forming a circle
101
102
next to the reviewers name at the top of the PR.
102
103
104
+
::: caution
105
+
106
+
## Help: Some checks have failed
107
+
108
+
Since our PR is running automatic checks it's best
109
+
not to make large changes by accepting suggestions this way.
110
+
Instead make changes to your feature branch using your local copy,
111
+
run the [checks locally](09-pre-commit.md),
112
+
push the changes to GitHub
113
+
and then mark the conversations with the suggested changes as resolved.
114
+
You can add a commit hash in the conversation which will automatically
115
+
link to the commit responding to any review comments.
116
+
117
+
:::
118
+
103
119
## Approving Changes
104
120
105
121
Head back to your partners PR, if they re-requested a review
0 commit comments