Skip to content

Commit c000156

Browse files
committed
Setup linting and prettier config.
1 parent 23c5f86 commit c000156

File tree

4 files changed

+47
-4
lines changed

4 files changed

+47
-4
lines changed

.eslintrc

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
{
2+
"extends": [
3+
"plugin:prettier/recommended",
4+
"plugin:promise/recommended",
5+
"plugin:react/recommended"
6+
],
7+
"parser": "babel-eslint",
8+
"parserOptions": {
9+
"ecmaFeatures": {
10+
"jsx": true
11+
}
12+
},
13+
"plugins": ["jest", "promise", "react"],
14+
"rules": {
15+
"react/display-name": "off",
16+
"react/prop-types": "off"
17+
},
18+
"settings": {
19+
"react": {
20+
"version": "16.3"
21+
}
22+
}
23+
}

.prettierrc

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"printWidth": 100,
3+
"semi": false,
4+
"trailingComma": "es5"
5+
}

package.json

+10-1
Original file line numberDiff line numberDiff line change
@@ -27,26 +27,35 @@
2727
],
2828
"scripts": {
2929
"build": "babel src -d lib",
30+
"lint": "eslint src",
3031
"test": "jest src",
3132
"test:watch": "npm run test -- --watch",
3233
"test:compat": "npm run test:backwards && npm run test:forwards && npm run test:latest",
3334
"test:backwards": "npm i [email protected] [email protected] && npm test",
3435
"test:forwards": "npm i react@next react-dom@next && npm test",
3536
"test:latest": "npm i react@latest react-dom@latest && npm test",
36-
"prepublishOnly": "npm run test:compat && npm run build"
37+
"prepublishOnly": "npm run lint && npm run test:compat && npm run build"
3738
},
3839
"dependencies": {},
3940
"peerDependencies": {
4041
"react": ">=16.3.1"
4142
},
4243
"devDependencies": {
4344
"babel-cli": "6.26.0",
45+
"babel-eslint": "10.0.1",
4446
"babel-preset-env": "1.7.0",
4547
"babel-preset-flow": "6.23.0",
4648
"babel-preset-react": "6.24.1",
4749
"babel-preset-stage-2": "6.24.1",
50+
"eslint": "5.11.1",
51+
"eslint-config-prettier": "3.3.0",
52+
"eslint-plugin-jest": "22.1.2",
53+
"eslint-plugin-prettier": "3.0.1",
54+
"eslint-plugin-promise": "4.0.1",
55+
"eslint-plugin-react": "7.12.0",
4856
"jest": "23.6.0",
4957
"jest-dom": "2.1.0",
58+
"prettier": "1.15.3",
5059
"react": "16.6.3",
5160
"react-dom": "16.6.3",
5261
"react-testing-library": "5.2.3"

src/spec.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ describe("Async", () => {
3131

3232
test("passes rejection error to children as render prop", async () => {
3333
const promiseFn = () => Promise.reject("oops")
34-
const { getByText } = render(<Async promiseFn={promiseFn}>{({ error }) => error || null}</Async>)
34+
const { getByText } = render(
35+
<Async promiseFn={promiseFn}>{({ error }) => error || null}</Async>
36+
)
3537
await waitForElement(() => getByText("oops"))
3638
})
3739

@@ -110,7 +112,9 @@ describe("Async", () => {
110112
}
111113
}
112114
const promiseFn = jest.fn().mockReturnValue(resolveTo())
113-
const { getByText } = render(<Counter>{count => <Async promiseFn={promiseFn} watch={count} />}</Counter>)
115+
const { getByText } = render(
116+
<Counter>{count => <Async promiseFn={promiseFn} watch={count} />}</Counter>
117+
)
114118
expect(promiseFn).toHaveBeenCalledTimes(1)
115119
fireEvent.click(getByText("increment"))
116120
expect(promiseFn).toHaveBeenCalledTimes(2)
@@ -327,7 +331,9 @@ describe("Async.Resolved", () => {
327331
const deferFn = () => rejectTo("fail")
328332
const { getByText, queryByText } = render(
329333
<Async promiseFn={promiseFn} deferFn={deferFn}>
330-
<Async.Resolved persist>{(data, { run }) => <button onClick={run}>{data}</button>}</Async.Resolved>
334+
<Async.Resolved persist>
335+
{(data, { run }) => <button onClick={run}>{data}</button>}
336+
</Async.Resolved>
331337
<Async.Rejected>{error => error}</Async.Rejected>
332338
</Async>
333339
)

0 commit comments

Comments
 (0)