-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: maximum value for SQS deliveryDelay
is 15 minutes, not 15 seconds
#566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@ssemyonov hi! Thanks for your contribution. Please move your change from auto generated schema to this schemas: |
deliveryDelay
maximum is 15 minutes, not 15 secondsdeliveryDelay
maximum is 15 minutes, not 15 seconds
|
deliveryDelay
maximum is 15 minutes, not 15 secondsdeliveryDelay
is 15 minutes, not 15 seconds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Good catch!
@dpwdec please remember next time to merge PRs using our commands, instead of doing it manually in GH. Just add we added this command automation because like in this PR and others in the past quite often we forget to make sure that commit message follows conventional commits. now, in |
Hello, @derberg! 👋🏼
|
Really sorry @derberg! Is there anything I can do to fix it? Reverting etc. Or can it be fixed forward for releases? |
no worries, I'm just letting you know for future. Nothing bad happened, unless it is a critical bug that needs to be somewhere fixed quickly 😄 we can revert, we can do dummy empty commit PR - or we can just wait for another PR that would trigger the release |
Description
According to AWS documentation the maximum amount of delay is 15 minutes and the property is set in seconds, therefore the maximum in the binding needs to be updated accordingly.