Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maximum value for SQS deliveryDelay is 15 minutes, not 15 seconds #566

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

ssemyonov
Copy link
Contributor

Description

According to AWS documentation the maximum amount of delay is 15 minutes and the property is set in seconds, therefore the maximum in the binding needs to be updated accordingly.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Pakisan
Copy link
Member

Pakisan commented Feb 11, 2025

@ssemyonov hi!

Thanks for your contribution. Please move your change from auto generated schema to this schemas:

@ssemyonov ssemyonov changed the title Fix - SQS deliveryDelay maximum is 15 minutes, not 15 seconds fix: SQS deliveryDelay maximum is 15 minutes, not 15 seconds Feb 11, 2025
@ssemyonov ssemyonov changed the title fix: SQS deliveryDelay maximum is 15 minutes, not 15 seconds fix: maximum value for SQS deliveryDelay is 15 minutes, not 15 seconds Feb 11, 2025
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Good catch!

@dpwdec dpwdec merged commit 92e94e4 into asyncapi:master Feb 12, 2025
12 of 13 checks passed
@ssemyonov ssemyonov deleted the patch-1 branch February 12, 2025 12:54
@derberg
Copy link
Member

derberg commented Feb 12, 2025

@dpwdec please remember next time to merge PRs using our commands, instead of doing it manually in GH. Just add /rtm comment. And don't worry if you can't remember, you can always just drop /help comment if needed.

we added this command automation because like in this PR and others in the past quite often we forget to make sure that commit message follows conventional commits. /rtm command makes sure commit message is the same as PR title.

now, in master we have commit message Fix - SQS deliveryDelay maximum is 15 minutes, not 15 seconds instead of fix: maximum value for SQS deliveryDelay is 15 minutes, not 15 seconds and no release is going to be triggered automatically

@asyncapi-bot
Copy link
Contributor

Hello, @derberg! 👋🏼

    I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

    At the moment the following comments are supported in pull requests:

    - `/please-take-a-look` or `/ptal` - This comment will add a comment to the PR asking for attention from the reviewrs who have not reviewed the PR yet.
    - `/ready-to-merge` or `/rtm` - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
    - `/do-not-merge` or `/dnm` - This comment will block automerging even if all conditions are met and ready-to-merge label is added
    - `/autoupdate` or `/au` - This comment will add `autoupdate` label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR. (Currently only works for upstream branches.)
    - `/update` or `/u` - This comment will update the PR with the latest changes from the target branch. Unless there is a merge conflict or it is a draft PR. NOTE: this only updates the PR once, so if you need to update again, you need to call the command again.

@dpwdec
Copy link
Collaborator

dpwdec commented Feb 12, 2025

Really sorry @derberg! Is there anything I can do to fix it? Reverting etc. Or can it be fixed forward for releases?
I'll ensure I use the slash commands in future 🙇

@derberg
Copy link
Member

derberg commented Feb 12, 2025

no worries, I'm just letting you know for future. Nothing bad happened, unless it is a critical bug that needs to be somewhere fixed quickly 😄

we can revert, we can do dummy empty commit PR - or we can just wait for another PR that would trigger the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants