Skip to content

Commit 0fffef3

Browse files
committed
Cleanup flake8 violations
1 parent 65c90f6 commit 0fffef3

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tests/test_typedef_model.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ def check_property(property_name: str):
134134
if key in source:
135135
assert value == source[key]
136136
else:
137-
assert value == None
137+
assert value is None
138138

139139
check_property("create_time")
140140
check_property("created_by")
@@ -169,7 +169,7 @@ def check_attribute(model: object, attribute_name: str, source: dict):
169169
value = type(attribute)(value)
170170
assert attribute == value
171171
else:
172-
assert getattr(model, attribute_name) == None
172+
assert getattr(model, attribute_name) is None
173173

174174

175175
def test_struct_defs(type_defs):
@@ -203,7 +203,7 @@ def test_classification_def(type_defs):
203203

204204

205205
def check_has_attributes(type_def: TypeDef, type_def_json: dict):
206-
for key in type_def_json.keys():
206+
for key in type_def_json:
207207
attribute_name = to_snake_case(key)
208208
assert hasattr(type_def, attribute_name)
209209

@@ -231,5 +231,7 @@ def test_business_metadata_def(type_defs):
231231
check_type_def_properties(business_metadata_def, business_metadata_def_json)
232232
check_has_attributes(business_metadata_def, business_metadata_def_json)
233233

234+
234235
def test_type_def_response(type_defs):
235236
type_def_response = TypeDefResponse(**type_defs)
237+
assert isinstance(type_def_response, TypeDefResponse)

0 commit comments

Comments
 (0)