Merge pull request #503 from atlanhq/APP-5372

APP-5372: Added validation checks for `CredentialClient.Creator()`

Author: Aryamanz29

pyatlan/client/credential.py

@@ -46,7 +46,12 @@ def creator(self, credential: Credential, test: bool = True) -> CredentialRespon
         (`False`) before creation, defaults to `True`.
         :returns: A CredentialResponse instance.
         :raises ValidationError: If the provided `credential` is invalid.
+        :raises InvalidRequestError: If `test` is `False` and the credential contains a `username` or `password`.
         """
+
+        if not test and any((credential.username, credential.password)):
+            raise ErrorCode.UNABLE_TO_CREATE_CREDENTIAL.exception_with_parameters()
+
         raw_json = self._client._call_api(
             api=CREATE_CREDENTIALS.format_path_with_params(),
             query_params={"testCredential": test},

pyatlan/errors.py

@@ -615,6 +615,13 @@ class ErrorCode(Enum):
         "Check the details of the server's message to correct your request.",
         InvalidRequestError,
     )
+    UNABLE_TO_CREATE_CREDENTIAL = (
+        400,
+        "ATLAN-PYTHON-400-071",
+        "Credentials cannot include a `username` or `password` when `test` is `False`.",
+        "Set `test` to `True` or remove `username` and `password`.",
+        InvalidRequestError,
+    )
     AUTHENTICATION_PASSTHROUGH = (
         401,
         "ATLAN-PYTHON-401-000",

tests/unit/test_credential_client.py

@@ -356,6 +356,33 @@ def test_creator_success(
     assert response.level is None
 
 
+@pytest.mark.parametrize(
+    "credential_data",
+    [
+        (
+            Credential(
+                name="test-name",
+                description="test-desc",
+                connector_config_name="test-ccn",
+                connector="test-conn",
+                connector_type="test-ct",
+                auth_type="test-at",
+                host="test-host",
+                port=123,
+                username="test-user",
+                password="test-password",
+                extra={"some": "value"},
+            )
+        ),
+    ],
+)
+def test_cred_creator_with_test_false_with_username_password(
+    credential_data, client: CredentialClient
+):
+    with pytest.raises(Exception, match="ATLAN-PYTHON-400-071"):
+        client.creator(credential=credential_data, test=False)
+
+
 @pytest.mark.parametrize("test_guid", [[123], set(), dict()])
 def test_cred_purge_by_guid_wrong_params_raises_validation_error(
     test_guid, client: CredentialClient