Merge pull request #65 from atlanhq/ACTIV-652

Refactor Integration Tests to work on devx.atlan.com

Author: cmgrote

.github/workflows/pytest.yaml

@@ -1,6 +1,10 @@
 name: Python package
 
-on: [pull_request, workflow_dispatch]
+on:
+  pull_request:
+  workflow_dispatch:
+  schedule:
+    - cron : '0 3 * * *' # At 01:00 Daily
 
 jobs:
   build:
@@ -34,4 +38,5 @@ jobs:
           MARK_API_KEY: ${{ secrets.MARK_ATLAN_API_KEY }}
           MARK_BASE_URL: https://mark.atlan.com
         run: |
-          pytest
+          pytest tests/unit
+          pytest tests/integration

pyatlan/client/atlan.py

@@ -13,6 +13,7 @@
     BaseSettings,
     HttpUrl,
     PrivateAttr,
+    ValidationError,
     parse_obj_as,
     validate_arguments,
 )
@@ -196,7 +197,7 @@ def _build_typedef_request(typedef: TypeDef) -> TypeDefResponse:
         )
     else:
         raise InvalidRequestException(
-            "Unable to update type definitions of category: " + typedef.category.value,
+            f"Unable to update type definitions of category: {typedef.category.value}",
             param="category",
         )
         # Throw an invalid request exception
@@ -284,6 +285,11 @@ def register_client(cls, client: "AtlanClient"):
     def get_default_client(cls) -> "Optional[AtlanClient]":
         return cls._default_client
 
+    @classmethod
+    def reset_default_client(cls):
+        """Sets the default_client to None"""
+        cls._default_client = None
+
     def __init__(self, **data):
         super().__init__(**data)
         self._request_params = {"headers": {"authorization": f"Bearer {self.api_key}"}}
@@ -844,7 +850,11 @@ def search(self, criteria: IndexSearchRequest) -> SearchResults:
             request_obj=criteria,
         )
         if "entities" in raw_json:
-            assets = parse_obj_as(list[Asset], raw_json["entities"])
+            try:
+                assets = parse_obj_as(list[Asset], raw_json["entities"])
+            except ValidationError as err:
+                LOGGER.error("Problem parsing JSON: %s", raw_json["entities"])
+                raise err
         else:
             assets = []
         count = raw_json["approximateCount"] if "approximateCount" in raw_json else 0

pyatlan/generator/templates/entity.jinja2

@@ -374,21 +374,7 @@ class {{ entity_def.name }}({{super_classes[0]}} {%- if "Asset" in super_classes
             self.announcement_title = None
             self.announcement_type = None
         {%- endif  %}
-        {%- if entity_def.name == "Connection"  %}
-        def validate_required(self):
-            if not self.name:
-                raise ValueError("name is required")
-            if not self.admin_roles and not self.admin_groups and not self.admin_users:
-                raise ValueError(
-                    "One of admin_user, admin_groups or admin_roles is required"
-                )
-            if not self.qualified_name:
-                raise ValueError("qualified_name is required")
-            if not self.category:
-                raise ValueError("category is required")
-            if not self.connector_name:
-                raise ValueError("connector_name is required")
-        {%- elif entity_def.name == "Process" %}
+        {%- if entity_def.name == "Process" %}
         @staticmethod
         def generate_qualified_name(
             name: str,