Fixes per review comments

Signed-off-by: Christopher Grote <[email protected]>

Author: cmgrote

pyatlan/client/constants.py

@@ -43,7 +43,7 @@
 CHANGE_USER_ROLE = API(
     USER_API + "/{user_guid}/roles/update", HTTPMethod.POST, HTTPStatus.OK
 )
-GET_CURRENT_USER = API(USER_API + "/current", HTTPMethod.GET, HTTPStatus.OK)
+GET_CURRENT_USER = API(f"{USER_API}/current", HTTPMethod.GET, HTTPStatus.OK)
 
 ENTITY_API = f"{BASE_URI}entity/"
 PREFIX_ATTR = "attr:"

tests/integration/admin_test.py

@@ -7,14 +7,10 @@
 
 from pyatlan.cache.role_cache import RoleCache
 
-import logging
-
 from pyatlan.client.atlan import AtlanClient
 from pyatlan.model.group import AtlanGroup, CreateGroupResponse
 from pyatlan.model.user import AtlanUser
 
-LOGGER = logging.getLogger(__name__)
-
 PREFIX = "psdk-Admin"
 GROUP_NAME1 = f"{PREFIX}1"
 GROUP_NAME2 = f"{PREFIX}2"
@@ -45,7 +41,6 @@ def test_retrieve_roles():
 @pytest.fixture(scope="module")
 def group1(client: AtlanClient) -> Generator[CreateGroupResponse, None, None]:
     g = create_group(client, GROUP_NAME1)
-    LOGGER.info(f"Created: {g}")
     yield g
     delete_group(client, g.group)
 
@@ -85,24 +80,15 @@ def test_update_groups(client: AtlanClient, group1: CreateGroupResponse):
 
 
 def _get_user1_from_list(users: list[AtlanUser]) -> Optional[AtlanUser]:
-    for user in users:
-        if user.email == USER_EMAIL1.lower():
-            return user
-    return None
+    return next((user for user in users if user.email == USER_EMAIL1.lower()), None)
 
 
 def _get_user2_from_list(users: list[AtlanUser]) -> Optional[AtlanUser]:
-    for user in users:
-        if user.email == USER_EMAIL2.lower():
-            return user
-    return None
+    return next((user for user in users if user.email == USER_EMAIL2.lower()), None)
 
 
 def _get_user3_from_list(users: list[AtlanUser]) -> Optional[AtlanUser]:
-    for user in users:
-        if user.email == USER_EMAIL3.lower():
-            return user
-    return None
+    return next((user for user in users if user.email == USER_EMAIL3.lower()), None)
 
 
 @pytest.fixture(scope="module")
@@ -153,7 +139,6 @@ def group2(
     user3 = _get_user3_from_list(users)
     assert user3  # must be here for mypy
     g = client.create_group(group=to_create, user_ids=[str(user2.id), str(user3.id)])
-    LOGGER.info(f"Created: {g}")
     yield g
     delete_group(client, g.group)
 

tests/integration/custom_metadata_test.py

@@ -371,8 +371,7 @@ def groups(
 ) -> Generator[List[CreateGroupResponse], None, None]:
     g1 = create_group(client, GROUP_NAME1)
     g2 = create_group(client, GROUP_NAME2)
-    created = [g1, g2]
-    yield created
+    yield [g1, g2]
     delete_group(client, g1.group)
     delete_group(client, g2.group)