Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Material UI - Can't change color #467

Open
BenceMatrai opened this issue Mar 5, 2018 · 28 comments
Open

Material UI - Can't change color #467

BenceMatrai opened this issue Mar 5, 2018 · 28 comments

Comments

@BenceMatrai
Copy link

Hey I can not change the main color from the default Teal. I'm using atom-material-ui with the atom-material-dark syntax theme.

Reproduction Steps:

  1. Open Themes, click gear icon next to Atom Material UI theme.
  2. Choose a color from the dropdown menu.
  3. Nothing happens.

Expected behavior:

Changed main color.

Observed behavior:

Nothing happens.

Screenshots and GIFs

image
As you can see here the colors do not change. (reboot tried)
Sidenote: Does not work either if i use the Atom Material syntax theme instead of the dark one.

Atom version: 1.32.0 x64
OS and version: Windows 10 latest update as of 18.03.05

Installed packages:

emmet
Auto-close
Beautify
minimap

@Fohdeesha
Copy link

having exact same issue

@lqzhgood
Copy link

lqzhgood commented Mar 9, 2018

I restored the color through the steps below.

  1. remove atom material package
  2. restart Atom
  3. install atom material package
  4. restart Atom
  5. change Perdefined colors
  6. restart Atom

is ok in 1.24.1 x64

@ghost
Copy link

ghost commented Mar 9, 2018

@lqzhgood This solution worked for me, but still there is some creepy issue here.

@BenceMatrai
Copy link
Author

@lqzhgood Thanks it worked!

@ghost
Copy link

ghost commented Mar 13, 2018

Hey all, I was having the same issue until I installed the atom-material-syntax package. Works like a charm

@iammruni
Copy link

@lqzhgood Thanks a lot!

@iammruni
Copy link

@BenceMatrai @Fohdeesha @karolfalkiewicz @lqzhgood... Btw I noticed something... Atom Material UI will work normally and change color instantly if your 'syntax theme' is NOT Atom Material Dark or Light. If you keep your syntax theme Atom Material Syntax and then change your UI theme to Atom Material you can change those colors like any other normal theme. Maybe those two syntax files are overriding the colors.

@tojason
Copy link

tojason commented Mar 24, 2018

I have the same issue, the change color only works with certain syntax theme. Looks like atom-material-ui isn't compatible with some other syntax theme. Need to fix the overriding issues.

@Zeklandia
Copy link

The problem only happens to me when atom-material-syntax-dark is set as the syntax theme.

@Extarys
Copy link

Extarys commented Apr 25, 2018

HJust restarting Atom for the change to take effect worked for me on 1.26.0

@PraxisPrime
Copy link

{Fixed}

not a coder so apologies for my non standard syntax, but below method will work. Not sure why "optional" is in the line as the theme works perfectly as described without it.

-delete (optional) from Line 104 in atom-material-ui>styles>ui-variables.less of theme project code
-reads....@import (optional) "user-settings";
-should read @import "user-settings";

Save file and then you will need to go back into theme options and then re pick your color.
Only negative I can see is it tints the tab bar and you have to go back and check/uncheck the "Tinted tab bar" option.

@gavsiu
Copy link

gavsiu commented Jul 14, 2018

Uninstalling, restarting, installing, restarting, changing colours, and restarting does not work for me. I didn't see how that would help anyway since I just installed the theme before encountering this issue.

Deleting (optional) from Line 104 broke Atom. It opened with dev tools only. Reverted the change and Atom opened normally.

Arch Linux
Atom v1.28.1
atom-material-ui v2.1.3

@levblanc
Copy link

Same issue here.

Tried reinstalling atom-material-ui package but didn't work.

version
MacOS v10.11.6
Atom v1.31.2
atom-material-ui v2.1.3

In my case, I found that atom-material-ui is just not working with the dracula-syntax,

if I change syntax theme to default ones like One Dark, or Atom Dark,

the predefined color actually works.

@aagerblad
Copy link

I have the same issue. Except it does not work with One Dark or Atom Dark. Changing the accent color work with all other syntax themes, but for those two it reverts back to the default green.

One Dark Using One Dark: Checkmarks are the wrong color

image Using One Light: Checkmarks are the right color

@fragmential
Copy link

@lqzhgood didn't work with me unfortunately.

@pksunkara
Copy link

I just had a new installation on my new computer and this happened. My old computer is having no issues though even though all the packages and atom versions and all the configurations are the same.

@pksunkara
Copy link

#467 (comment) worked for me

@codefaux
Copy link

Just had this issue myself - one system worked fine after fiddling around with it for a while, the other didn't. As a few have, I attempted to apply the thing from comment 467 above, and my Atom also crashed.

The difference is, the system that worked DOES have user-settings.less, whereas the system with problems -- ie, crashing with the removed (Optional) flag -- does NOT. Upon manually creating the file, with matching contents, all works as expected.

I would hazard a guess that it's failing to create the file for one reason or another, if someone could let me know how to narrow it down further I'll gladly do so. Meantime - here's my user-settings.less, wholesale;

@accent-color: #ffffff; @accent-text-color: rgba(255,255,255,0.8); @base-color: #795548;

Maybe one of you lot experiencing the bug should put that in packages\atom-material-ui\styles\user-settings.less and see if things start working, IE if you can change colors and have it persist, etc...?

@marcosilvestroni
Copy link

In my case there's a a conflict with atom-material-syntax, after removed/switched the syntax theme everything works!

@NodeJoSe
Copy link

NodeJoSe commented Jul 8, 2020

In my case there's a a conflict with atom-material-syntax, after removed/switched the syntax theme everything works!

Some syntaxes just shows that default Teal color, I still have this issue.

@janusson
Copy link

janusson commented Sep 9, 2020

Can I temporarily fix this issue by modifying the user stylesheet?

@ghost
Copy link

ghost commented Nov 1, 2020

I restored the color through the steps below.

  1. remove atom material package
  2. restart Atom
  3. install atom material package
  4. restart Atom
  5. change Perdefined colors
  6. restart Atom

is ok in 1.24.1 x64

It works for me. Thanks! :D.

@monster010
Copy link

For me the problem was with atom-material-syntax! If, on the other hand, I use atom-material-syntax-dark, the problem is eliminated.

@ghost
Copy link

ghost commented Jan 4, 2021 via email

@ghost
Copy link

ghost commented Jan 4, 2021 via email

@ghost
Copy link

ghost commented Apr 4, 2021

-delete (optional) from Line 104 in atom-material-ui>styles>ui-variables.less of theme project code
-reads....@import (optional) "user-settings";
-should read @import "user-settings";

This worked! Thanks a ton!

@DhruvSiri
Copy link

@monster010 Thanks it worked... but I think there should be a way to solve this otherwise, and let u use the normal one.
does anyone know such a way

@DhruvSiri
Copy link

#467 thanks that worked

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests