Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit b8248b4

Browse files
authored
Merge pull request #1137 from Aerijo/workaround-devtools
Add devtools catch
2 parents 528679c + 8172c89 commit b8248b4

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

spec/setup-spec.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,18 @@ require('etch').setScheduler({
22
updateDocument(callback) { callback(); },
33
getNextUpdatePromise() { return Promise.resolve(); }
44
});
5+
6+
// The CI on Atom has been failing with this package. Experiments
7+
// indicate the dev tools were being opened, which caused test
8+
// failures. Dev tools are meant to be triggered on an uncaught
9+
// exception.
10+
//
11+
// These failures are flaky though, so an exact cause
12+
// has not yet been found. For now the following is added
13+
// to reduce the number of flaky failures, which have been
14+
// causing false failures on unrelated Atom PRs.
15+
//
16+
// See more in https://github.com/atom/atom/pull/21335
17+
global.beforeEach(() => {
18+
spyOn(atom, 'openDevTools').andReturn((console.error("ERROR: Dev tools attempted to open"), Promise.resolve()));
19+
});

0 commit comments

Comments
 (0)