Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create GadgetSpace without an extended window or extended window config. #2

Open
davija opened this issue Oct 23, 2013 · 6 comments

Comments

@davija
Copy link
Member

davija commented Oct 23, 2013

If you try and create a GadgetSpace without passing in an extended window config object, you get the following error:
Uncaught TypeError: Cannot read property 'configMap' of undefined smithy-0.1.7-min.js:18

smithy should NOT assume that an extended window or extended window config will be available. It is quite common for apps to be single-window only.

@tom-servo
Copy link
Contributor

Should be fixed in the current version 0.1.7...

@tom-servo tom-servo reopened this Oct 23, 2013
@tom-servo
Copy link
Contributor

Ah, it was ssmith7's commit a58a5ca that fixed it. That wasn't in 0.1.7. I need to publish a new version.

@srsmith
Copy link

srsmith commented Oct 23, 2013

Yeah I ran into that a while ago but I think I checked it into a previous version. 0.1.6 perhaps?

@tom-servo
Copy link
Contributor

looking at the dates... your commit was three months ago and the 0.1.7 was 4 months ago. I think I just forgot to publish a new version...

@srsmith
Copy link

srsmith commented Oct 23, 2013

Ah gotcha - thanks.

@tom-servo
Copy link
Contributor

Thanks for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants