Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (at_onboarding_cli): write keys before deleting cram secret #763

Open
XavierChanth opened this issue Jan 28, 2025 · 2 comments
Open
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Jan 28, 2025

Reason: Keys must be written before deleting the cram secret, otherwise the atServer must be reset to continue.

The decision here has an impact on a change to atServer that @gkc will be making:
If there is an approved firstApp enrollment, and the cram secret is still in place, then new firstApp enrollments will replace the existing one. (Currently they are denied)

  • We can either prefer immediately before deleting cram secret
    • I think this is preferred once the above atServer change is made, as if there is a failure, in one of the operations, the keys will not be overridden and the re-running the cli will be able to self-recover
  • Or we can do it immediately before deleting the cram secret
    • Preferred without the atServer change, because it can be manually recovered, but not automatically recovered by re-running the cli.
@XavierChanth
Copy link
Member Author

Going to hold off on this change until C version's done, aiming to get a release out ASAP

@XavierChanth XavierChanth removed their assignment Feb 3, 2025
@gkc
Copy link
Contributor

gkc commented Feb 17, 2025

Will complete in PR 106. Changed priority to P1 as encountering this failure would be very annoying as well as driving operations load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants