feat: Add Self Service Profiles endpoints #795
Conversation
…iles # Conflicts: # src/API/Management.php # src/Contract/API/ManagementInterface.php
|
Claude finished @kishore7snehil's task —— View job Code Review Progress
Overall Assessment❌ This PR requires minor fixes before merging. I've identified a typo in the test file, an HTTP method case inconsistency, and a redundant null check that should be addressed to maintain code quality and consistency with the rest of the codebase. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| test('revokeSsoTicket() issues an appropriate request', function(): void { | ||
| $id = uniqid(); | ||
| $prfileId = uniqid(); |
There was a problem hiding this comment.
Typo in variable name: $prfileId should be $profileId to match the parameter name in the method signature and improve code readability.
| ->method('PUT') | ||
| ->addPath(['self-service-profiles', $id, 'custom-text', $language, $page]) | ||
| ->withOptions($options) | ||
| ->withBody($body ?? []) |
There was a problem hiding this comment.
Redundant null coalescing operator: The $body ?? [] is unnecessary since $body has already been filtered and trimmed on line 169. After filtering, $body will be an array (empty array if null was passed). This redundant check adds confusion about the actual state of $body.
| ])->isString(); | ||
|
|
||
| return $this->getHttpClient() | ||
| ->method('PUT') |
There was a problem hiding this comment.
HTTP method case inconsistency: This method uses 'PUT' in uppercase while all other methods in the class use lowercase ('post', 'get', 'delete', 'patch'). For consistency with the rest of the codebase, this should be 'put' in lowercase.
2 participants
Changes
Adding the Self Service Profiles API endpoints to the Management API. This has been added in other language versions, but not in the PHP library.
References
Self Service Profiles
Testing
All new endpoints have 100% code coverage.
Contributor Checklist