fix: execution order for logStreams#1175
Merged
kushalshit27 merged 7 commits intoOct 10, 2025
Merged
Conversation
- src/tools/auth0/handlers/logStreams.ts: import 'order' decorator and apply it to processChanges method - src/tools/auth0/index.ts: improve sortByOrder function to handle NaN cases and ensure proper sorting of handlers by order
Contributor
Author
This comment was marked as outdated.
This comment was marked as outdated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1175 +/- ##
==========================================
- Coverage 80.23% 80.17% -0.07%
==========================================
Files 134 134
Lines 5096 5100 +4
Branches 1013 1014 +1
==========================================
Hits 4089 4089
- Misses 578 579 +1
- Partials 429 432 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
This comment was marked as resolved.
This comment was marked as resolved.
clientGrants processes before logStreams
clientGrants processes before logStreamslogStreams
Contributor
Author
|
Claude finished @kushalshit27's task —— View job Review Progress
Overall Assessment❌ The PR has several issues that should be addressed before merging. While the order decorator validation is solid, the execution order choice creates ambiguity, the sorting function has a minor inefficiency, lacks defensive NaN handling, and there's no test coverage for the critical sorting logic. Key Concerns:
Strengths:
Job Run | Branch: |
ramya18101
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fix handler execution order to ensure
clientGrantsprocesses beforelogStreamsSolution:
@order('70')decorator tologStreamsto ensure it executes afterclientGrants(priority 60)📚 References
🔬 Testing
📝 Checklist