Try to fix failing tests

Author: RaghuSpaceRajan

experiments/dqn_image_representations.py

@@ -19,6 +19,11 @@
 agent_config specifies static agent configurations
 model_config specifies static NN model configurations
 eval_config specifies static evaluation configurations
+
+NOTE: Please note that for any configuration values not provided here, reasonable
+default values would be used. As such, these config values are much more verbose
+than needed. We only explicitly provide many important configuration values here
+to have them be easy to find.
 """
 from ray import tune
 from collections import OrderedDict

experiments/dqn_image_representations_sh_quant.py

@@ -19,6 +19,11 @@
 agent_config specifies static agent configurations
 model_config specifies static NN model configurations
 eval_config specifies static evaluation configurations
+
+NOTE: Please note that for any configuration values not provided here, reasonable
+default values would be used. As such, these config values are much more verbose
+than needed. We only explicitly provide many important configuration values here
+to have them be easy to find.
 """
 import itertools
 from ray import tune

mdp_playground/spaces/image_continuous.py

@@ -102,6 +102,7 @@ def __init__(
 
         if self.target_point is not None:
             if self.draw_grid:
+                target_point = target_point.astype(float)
                 target_point += 0.5
             self.target_point_pixel = self.convert_to_pixel(target_point)
 

mdp_playground/spaces/test_image_continuous.py

@@ -11,6 +11,7 @@
 
 class TestImageContinuous(unittest.TestCase):
     def test_image_continuous(self):
+        render = False
         lows = 0.0
         highs = 20.0
         cs2 = Box(
@@ -26,24 +27,25 @@ def test_image_continuous(self):
 
         imc = ImageContinuous(
             cs2,
-            width=100,
-            height=100,
+            width=400,
+            height=400,
         )
         pos = np.array([5.0, 7.0])
         img1 = Image.fromarray(np.squeeze(imc.generate_image(pos)), "RGB")
         # img1 = ImageOps.invert(img1)
-        img1.show()
+        if render: img1.show()
         # img1.save("cont_state_no_target.pdf")
 
         target = np.array([10, 10])
         imc = ImageContinuous(
             cs2,
+            circle_radius=10, 
             target_point=target,
-            width=100,
-            height=100,
+            width=400,
+            height=400,
         )
         img1 = Image.fromarray(np.squeeze(imc.generate_image(pos)), "RGB")
-        img1.show()
+        if render: img1.show()
         # img1.save("cont_state_target.pdf")
 
         # Terminal sub-spaces
@@ -65,13 +67,14 @@ def test_image_continuous(self):
         imc = ImageContinuous(
             cs2,
             target_point=target,
+            circle_radius=10, 
             term_spaces=term_spaces,
-            width=100,
-            height=100,
+            width=400,
+            height=400,
         )
         pos = np.array([5.0, 7.0])
         img1 = Image.fromarray(np.squeeze(imc.get_concatenated_image(pos)), "RGB")
-        img1.show()
+        if render: img1.show()
         # img1.save("cont_state_target_terminal_states.pdf")
 
         # Irrelevant features
@@ -84,7 +87,7 @@ def test_image_continuous(self):
         )
         pos = np.array([5.0, 7.0, 10.0, 15.0])
         img1 = Image.fromarray(np.squeeze(imc.get_concatenated_image(pos)), "RGB")
-        img1.show()
+        if render: img1.show()
         # print(imc.get_concatenated_image(pos).shape)
 
         # Random sample and __repr__
@@ -96,14 +99,58 @@ def test_image_continuous(self):
         )
         # print(imc)
         img1 = Image.fromarray(np.squeeze(imc.sample()), "RGB")
-        img1.show()
+        if render: img1.show()
 
         # Draw grid
+        grid_shape=(5, 5)
+        cs2_grid = Box(
+            low=0 * np.array(grid_shape).astype(np.float64),
+            high=np.array(grid_shape).astype(np.float64),
+        )
+        pos = np.array([2, 3])
+        target = np.array([4, 4])
         imc = ImageContinuous(
-            cs4, target_point=target, width=400, height=400, grid=(5, 5)
+            cs2_grid, 
+            target_point=target, 
+            circle_radius=10, 
+            width=400, 
+            height=400, 
+            grid_shape=grid_shape
         )
-        img1 = Image.fromarray(np.squeeze(imc.sample()), "RGB")
-        img1.show()
+        img1 = Image.fromarray(np.squeeze(imc.get_concatenated_image(pos)), "RGB")
+        if render: img1.show()
+        # img1.save("grid_target.pdf")
+
+        # Grid with terminal sub-spaces
+        lows = np.array([2.0, 4.0])
+        highs = np.array([2.0, 4.0])
+        cs2_term1 = Box(
+            low=lows,
+            high=highs,
+        )
+        lows = np.array([1.0, 1.0])
+        highs = np.array([1.0, 1.0])
+        cs2_term2 = Box(
+            low=lows,
+            high=highs,
+        )
+        term_spaces = [cs2_term1, cs2_term2]
+
+        pos = np.array([2, 3])
+        target = np.array([4, 4])
+        imc = ImageContinuous(
+            cs2_grid,
+            circle_radius=10, 
+            target_point=target, 
+            term_spaces=term_spaces,
+            width=400, 
+            height=400, 
+            grid_shape=grid_shape
+        )
+        img1 = Image.fromarray(np.squeeze(imc.get_concatenated_image(pos)), "RGB")
+        if render: img1.show()
+        # img1.save("grid_target_terminal_states.pdf")
+
 
 
 if __name__ == "__main__":

setup.py

@@ -24,7 +24,7 @@
 
 extras_require_disc = [
     "ray[rllib,debug]==0.7.3",
-    "tensorflow==1.13.0rc1",
+    "tensorflow==1.13.1",
     "pillow>=6.1.0",
     "requests==2.22.0",
     "configspace==0.4.10",