Avoid a test panic that's easy to trigger

Author: teor2345

crates/sp-domains-fraud-proof/src/tests.rs

@@ -39,7 +39,7 @@ async fn benchmark_bundle_with_evm_tx(
     mut alice: EvmDomainNode,
     mut ferdie: MockConsensusNode,
 ) -> (Vec<Vec<u8>>, StorageProof) {
-    let account_infos = (1..tx_to_create)
+    let account_infos = (0..tx_to_create)
         .map(|i| address_build(i as u128))
         .collect::<Vec<AccountInfo>>();
 
@@ -606,7 +606,7 @@ async fn test_evm_domain_block_fee() {
     // Create more accounts and fund these accounts
     let tx_to_create = 3;
     let account_infos = (0..tx_to_create)
-        .map(|i| address_build(i as u128 + 1))
+        .map(|i| address_build(i as u128))
         .collect::<Vec<AccountInfo>>();
     let alice_balance = alice.free_balance(Alice.to_account_id());
     for (i, account_info) in account_infos.iter().enumerate() {

crates/sp-domains/src/test_ethereum_tx.rs

@@ -26,8 +26,10 @@ pub struct AccountInfo {
 }
 
 /// Returns an AccountInfo struct with a deterministic address and private key.
-/// Seed zero produces an invalid private key.
-pub fn address_build(seed: u128) -> AccountInfo {
+/// Seed zero produces an invalid private key, so we add one to the supplied seed.
+pub fn address_build(mut seed: u128) -> AccountInfo {
+    seed += 1;
+
     let mut seed_bytes = [0u8; 32];
     seed_bytes[0..16].copy_from_slice(&seed.to_be_bytes());
     let private_key = H256::from_slice(&seed_bytes);

domains/client/domain-operator/src/tests.rs

@@ -290,7 +290,7 @@ async fn test_evm_domain_create_contracts_with_allow_list() {
     // Create more accounts and fund these accounts
     let tx_to_create = 5;
     let account_infos = (0..tx_to_create)
-        .map(|i| address_build(i as u128 + 1))
+        .map(|i| address_build(i as u128))
         .collect::<Vec<AccountInfo>>();
     let alice_balance = alice.free_balance(Alice.to_account_id());
     for (i, account_info) in account_infos.iter().enumerate() {
@@ -4710,7 +4710,7 @@ async fn test_domain_sudo_calls() {
     // once the call is executed in the domain, list will be updated.
     let accounts_to_create = 4;
     let account_infos = (0..accounts_to_create)
-        .map(|i| address_build(i as u128 + 1))
+        .map(|i| address_build(i as u128))
         .collect::<Vec<AccountInfo>>();
 
     // Start with a redundant set to make sure the test framework works.