passt: Cover the passt attribute hostname and fqdn

Cover the bug https://issues.redhat.com/browse/RHEL-79806.
Since it needs to captures the DHCP packets via tshark in the guest,
wireshark-cli should be installed when preparing the guest image.

Signed-off-by: Han Han <[email protected]>

Author: qiankehan

libvirt/tests/cfg/virtual_network/passt/passt_function.cfg

@@ -86,3 +86,12 @@
         - vhostuser:
             vhostuser = yes
             func_supported_since_libvirt_ver = (10, 10, 0)
+    variants:
+        - no_domain_name_opts:
+            use_domain_name_opts = no
+        - domain_name_opts:
+            use_domain_name_opts = yes
+            func_supported_since_libvirt_ver = (11, 8, 0)
+            hostname = 'test1'
+            fqdn = 'test2.libvirt.passt'
+            proc_checks = ['--hostname ${hostname}', '--fqdn ${fqdn}']

libvirt/tests/src/virtual_network/passt/passt_function.py

@@ -1,6 +1,7 @@
 import logging
 import os
 import shutil
+import time
 from avocado.utils import process
 
 import aexpect
@@ -73,6 +74,7 @@ def run(test, params, env):
     multiple_nexthops = 'yes' == params.get('multiple_nexthops', 'no')
     libvirtd_debug_file = params.get('libvirtd_debug_file')
     warning_check = params.get('warning_check')
+    use_domain_name_opts = 'yes' == params.get('use_domain_name_opts')
 
     vmxml = vm_xml.VMXML.new_from_inactive_dumpxml(vm_name,
                                                    virsh_instance=virsh_ins)
@@ -100,6 +102,13 @@ def run(test, params, env):
             virtqemud_config = VirtQemudConfig()
             virtqemud_config.log_outputs = "1:file:{0}".format(libvirtd_debug_file)
             utils_libvirtd.Libvirtd('virtqemud').restart()
+
+        if use_domain_name_opts:
+            hostname = params.get('hostname')
+            fqdn = params.get('fqdn')
+            iface_attrs['backend']['hostname'] = hostname
+            iface_attrs['backend']['fqdn'] = fqdn
+
         libvirt_vmxml.modify_vm_device(vmxml, 'interface', iface_attrs,
                                        virsh_instance=virsh_ins)
         LOG.debug(virsh_ins.dumpxml(vm_name).stdout_text)
@@ -119,6 +128,31 @@ def run(test, params, env):
         passt.check_vm_mtu(session, vm_iface, mtu)
         passt.check_default_gw(session, host_iface, multiple_nexthops)
         passt.check_nameserver(session)
+        if use_domain_name_opts:
+            session.cmd(
+                'tshark -f "udp port 67 or 68 or 546 or 547" -T json -e dhcp.fqdn.name -e dhcpv6.client_domain -e dhcp.option.hostname > dhcp.json &')
+            session.cmd('systemctl restart NetworkManager')
+            time.sleep(5)
+            session.cmd('killall tshark')
+            for dhcp_opt_key in ['dhcp.option.hostname', 'dhcp.fqdn.name', 'dhcpv6.client_domain']:
+                jq_query = '''jq '[.[] | ._source.layers."{0}"[]?] | unique[]' dhcp.json'''.format(dhcp_opt_key)
+                status, dhcp_opt_val = session.cmd_status_output(jq_query)
+                if status:
+                    test.fail("Fail to run the jq cmd in guest: {0}".format(jq_query))
+                if len(dhcp_opt_val.split()) != 1:
+                    test.fail(
+                        'Expect to get only 1 value from dhcp option {0} but failed'.format(dhcp_opt_key))
+                if dhcp_opt_key == 'dhcp.option.hostname':
+                    if hostname not in dhcp_opt_val:
+                        test.fail('The hostname={0} in domain XML does not match the result {1}={2} in tshark'.format(
+                            hostname, dhcp_opt_key, dhcp_opt_val))
+                else:
+                    # Note: the fqdn with trailing dot will cause this check fail. It is a wireshark dissectors issue
+                    # E.g: fqdn=xxx.xxx. , wireshark will represent it like dhcp_fqdn_name=xxx.xxx
+                    # see also https://bugs.passt.top/show_bug.cgi?id=170
+                    if fqdn not in dhcp_opt_val:
+                        test.fail('The dhcp fqdn={0} in domain XML does not match the result {1}={2} in tshark'.format(
+                            fqdn, dhcp_opt_key, dhcp_opt_val))
 
         ips = {
             'outside_ip': outside_ip,