refactor: *environment.readOnly bool instead of func() bool

Author: ARR4N

core/vm/contracts.libevm.go

@@ -91,7 +91,7 @@ func (p statefulPrecompile) Run([]byte) ([]byte, error) {
 func (args *evmCallArgs) env() *environment {
 	return &environment{
 		evm:      args.evm,
-		readonly: args.readOnly,
+		readOnly: args.readOnly(),
 		addrs: libevm.AddressContext{
 			Origin: args.evm.Origin,
 			Caller: args.caller.Address(),

core/vm/environment.libevm.go

@@ -42,13 +42,13 @@ var _ Environment = (*environment)(nil)
 
 type environment struct {
 	evm      *EVM
-	readonly func() bool
+	readOnly bool
 	addrs    libevm.AddressContext
 }
 
 func (e *environment) ChainConfig() *params.ChainConfig  { return e.evm.chainConfig }
 func (e *environment) Rules() params.Rules               { return e.evm.chainRules }
-func (e *environment) ReadOnly() bool                    { return e.readonly() }
+func (e *environment) ReadOnly() bool                    { return e.readOnly }
 func (e *environment) ReadOnlyState() libevm.StateReader { return e.evm.StateDB }
 func (e *environment) Addresses() *libevm.AddressContext { return &e.addrs }
 func (e *environment) BlockNumber() *big.Int             { return new(big.Int).Set(e.evm.Context.BlockNumber) }

core/vm/jump_table.libevm.go

@@ -36,7 +36,7 @@ func (fn OperationFunc) internal() executionFunc {
 	return func(pc *uint64, interpreter *EVMInterpreter, scope *ScopeContext) ([]byte, error) {
 		env := &environment{
 			evm:      interpreter.evm,
-			readonly: func() bool { return interpreter.readOnly },
+			readOnly: interpreter.readOnly,
 			addrs: libevm.AddressContext{
 				Origin: interpreter.evm.Origin,
 				Caller: scope.Contract.CallerAddress,