Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: migrate eip-712 support to ethers-rs #85

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

*: migrate eip-712 support to ethers-rs #85

wants to merge 4 commits into from

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Nov 16, 2022 •
edited
Loading

This PR blocks the ability to push to crates.io.

Outstanding

  • decode
  • mempool
  • tests
  • add e2e

NOTE: still working through correctness

Signed-off-by: Sam Batschelet [email protected]

@hexfusion hexfusion marked this pull request as draft November 16, 2022 11:50
@hexfusion hexfusion added the WIP Work in progress label Nov 16, 2022
@hexfusion hexfusion added this to the [email protected] milestone Nov 16, 2022
@hexfusion hexfusion self-assigned this Nov 16, 2022
@hexfusion hexfusion linked an issue Nov 16, 2022 that may be closed by this pull request
Migrate EIP-712 dep to ethers-rs #78
Open
@hexfusion hexfusion marked this pull request as ready for review November 16, 2022 16:25
@hexfusion
tx: value as string
bfa1c30 
Signed-off-by: Sam Batschelet <[email protected]>
@hexfusion
nit
e875bf8 
Signed-off-by: Sam Batschelet <[email protected]>
This was referenced Nov 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hexfusion hexfusion

Labels
WIP Work in progress
Projects
None yet
Milestone
[email protected]
Development

Successfully merging this pull request may close these issues.

Migrate EIP-712 dep to ethers-rs
1 participant
@hexfusion