Skip to content

Commit ecd0c9d

Browse files
benthorneravaldebe
authored andcommitted
Move logger config to CLI module
Previously we configured the root logger in the PMS package itself, which would mean any code using the package as a library would get the logging config as a side effect. Rather than configure the root logger, which should be left to the toplevel program, this re-scopes how we set the config to apply to just the specific logger for the package.
1 parent f5613db commit ecd0c9d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/pms/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
import logging
2-
import os
32

4-
logging.basicConfig(level=os.getenv("LEVEL", "WARNING"))
53
logger = logging.getLogger(__name__)
64

75

src/pms/cli.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import logging
2+
import os
13
import sys
24
from datetime import datetime
35
from enum import Enum
@@ -25,6 +27,9 @@
2527
main.command(name=ep.name)(ep.load())
2628

2729

30+
logging.basicConfig(level=os.getenv("LEVEL", "WARNING"))
31+
32+
2833
def version_callback(value: bool): # pragma: no cover
2934
if not value:
3035
return
@@ -45,8 +50,7 @@ def callback(
4550
version: Optional[bool] = Option(None, "--version", "-V", callback=version_callback),
4651
):
4752
"""Read serial sensor"""
48-
if debug: # pragma: no cover
49-
logger.setLevel("DEBUG")
53+
logger.setLevel("DEBUG" if debug else os.getenv("LEVEL", "WARNING"))
5054
ctx.obj = {"reader": SensorReader(model, port, seconds, samples)}
5155

5256

0 commit comments

Comments
 (0)