Skip to content

Commit 5a089b7

Browse files
MorFixMorFix
committed
feat: Add support for JS and TS interfaces/unions
1 parent e6ac948 commit 5a089b7

File tree

5 files changed

+166
-33
lines changed

5 files changed

+166
-33
lines changed

‎packages/appsync-modelgen-plugin/src/languages/typescript-declaration-block.ts‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,21 @@ export class TypeScriptDeclarationBlock {
255255
}
256256

257257
protected generateInterface(): string {
258-
throw new Error('Not implemented yet');
258+
const header = [
259+
this._flags.shouldExport ? 'export' : '',
260+
this._flags.isDeclaration ? 'declare' : '',
261+
'interface',
262+
this._name,
263+
'{',
264+
];
265+
266+
if (this._extends.length) {
267+
header.push(['extends', this._extends.join(', ')].join(' '));
268+
}
269+
270+
const body = [this.generateProperties()];
271+
272+
return [`${header.filter(h => h).join(' ')}`, indentMultiline(body.join('\n')), '}'].join('\n');
259273
}
260274

261275
protected generateType(): string {

‎packages/appsync-modelgen-plugin/src/preset.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,7 @@ const generateJavasScriptPreset = (
216216
filename: join(modelFolder, 'index.d.ts'),
217217
config: {
218218
...options.config,
219+
target: 'typescript',
219220
scalars: { ...TYPESCRIPT_SCALAR_MAP, ...options.config.scalars },
220221
metadata: false,
221222
isDeclaration: true,

‎packages/appsync-modelgen-plugin/src/visitors/appsync-json-metadata-visitor.ts‎

Lines changed: 73 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -8,21 +8,35 @@ import {
88
ParsedAppSyncModelConfig,
99
RawAppSyncModelConfig,
1010
CodeGenEnum,
11+
CodeGenUnion,
12+
CodeGenInterface,
1113
} from './appsync-visitor';
1214
import { METADATA_SCALAR_MAP } from '../scalars';
1315
export type JSONSchema = {
1416
models: JSONSchemaModels;
1517
enums: JSONSchemaEnums;
1618
nonModels: JSONSchemaTypes;
19+
interfaces: JSONSchemaInterfaces;
20+
unions: JSONSchemaUnions;
1721
version: string;
1822
codegenVersion: string;
1923
};
2024
export type JSONSchemaModels = Record<string, JSONSchemaModel>;
2125
export type JSONSchemaTypes = Record<string, JSONSchemaNonModel>;
26+
export type JSONSchemaInterfaces = Record<string, JSONSchemaInterface>;
27+
export type JSONSchemaUnions = Record<string, JSONSchemaUnion>;
2228
export type JSONSchemaNonModel = {
2329
name: string;
2430
fields: JSONModelFields;
2531
};
32+
export type JSONSchemaInterface = {
33+
name: string;
34+
fields: JSONModelFields;
35+
};
36+
export type JSONSchemaUnion = {
37+
name: string;
38+
types: JSONModelFieldType[];
39+
};
2640
type JSONSchemaModel = {
2741
name: string;
2842
attributes?: JSONModelAttributes;
@@ -58,7 +72,7 @@ type AssociationBelongsTo = AssociationBaseType & {
5872

5973
type AssociationType = AssociationHasMany | AssociationHasOne | AssociationBelongsTo;
6074

61-
type JSONModelFieldType = keyof typeof METADATA_SCALAR_MAP | { model: string } | { enum: string } | { nonModel: string };
75+
type JSONModelFieldType = keyof typeof METADATA_SCALAR_MAP | { model: string } | { enum: string } | { nonModel: string } | { interface: string } | { union: string };
6276
type JSONModelField = {
6377
name: string;
6478
type: JSONModelFieldType;
@@ -160,6 +174,8 @@ export class AppSyncJSONVisitor<
160174
models: {},
161175
enums: {},
162176
nonModels: {},
177+
interfaces: {},
178+
unions: {},
163179
// This is hard-coded for the schema version purpose instead of codegen version
164180
// To avoid the failure of validation method checkCodegenSchema in JS Datastore
165181
// The hard code is starting from amplify codegen major version 4
@@ -175,11 +191,19 @@ export class AppSyncJSONVisitor<
175191
return { ...acc, [nonModel.name]: this.generateNonModelMetadata(nonModel) };
176192
}, {});
177193

194+
const interfaces = Object.values(this.getSelectedInterfaces()).reduce((acc, codegenInterface: CodeGenInterface) => {
195+
return { ...acc, [codegenInterface.name]: this.generateInterfaceMetadata(codegenInterface) };
196+
}, {});
197+
198+
const unions = Object.values(this.getSelectedUnions()).reduce((acc, union: CodeGenUnion) => {
199+
return { ...acc, [union.name]: this.generateUnionMetadata(union) };
200+
}, {});
201+
178202
const enums = Object.values(this.enumMap).reduce((acc, enumObj) => {
179203
const enumV = this.generateEnumMetadata(enumObj);
180204
return { ...acc, [this.getEnumName(enumObj)]: enumV };
181205
}, {});
182-
return { ...result, models, nonModels: nonModels, enums };
206+
return { ...result, models, nonModels: nonModels, enums, interfaces, unions };
183207
}
184208

185209
private getFieldAssociation(field: CodeGenField): AssociationType | void {
@@ -229,39 +253,58 @@ export class AppSyncJSONVisitor<
229253
private generateNonModelMetadata(nonModel: CodeGenModel): JSONSchemaNonModel {
230254
return {
231255
name: this.getModelName(nonModel),
232-
fields: nonModel.fields.reduce((acc: JSONModelFields, field: CodeGenField) => {
233-
const fieldMeta: JSONModelField = {
234-
name: this.getFieldName(field),
235-
isArray: field.isList,
236-
type: this.getType(field.type),
237-
isRequired: !field.isNullable,
238-
attributes: [],
239-
};
240-
241-
if (field.isListNullable !== undefined) {
242-
fieldMeta.isArrayNullable = field.isListNullable;
243-
}
256+
fields: this.generateFieldsMetadata(nonModel.fields)
257+
};
258+
}
244259

245-
if (field.isReadOnly !== undefined) {
246-
fieldMeta.isReadOnly = field.isReadOnly;
247-
}
260+
private generateInterfaceMetadata(codeGenInterface: CodeGenInterface): JSONSchemaInterface {
261+
return {
262+
name: codeGenInterface.name,
263+
fields: this.generateFieldsMetadata(codeGenInterface.fields),
264+
};
265+
}
248266

249-
const association: AssociationType | void = this.getFieldAssociation(field);
250-
if (association) {
251-
fieldMeta.association = association;
252-
}
253-
acc[fieldMeta.name] = fieldMeta;
254-
return acc;
255-
}, {}),
267+
private generateUnionMetadata(codeGenUnion: CodeGenUnion): JSONSchemaUnion {
268+
return {
269+
name: codeGenUnion.name,
270+
types: codeGenUnion.typeNames.map(t => this.getType(t))
256271
};
257272
}
273+
258274
private generateEnumMetadata(enumObj: CodeGenEnum): JSONSchemaEnum {
259275
return {
260276
name: enumObj.name,
261277
values: Object.values(enumObj.values),
262278
};
263279
}
264280

281+
private generateFieldsMetadata(fields: CodeGenField[]): JSONModelFields {
282+
return fields.reduce((acc: JSONModelFields, field: CodeGenField) => {
283+
const fieldMeta: JSONModelField = {
284+
name: this.getFieldName(field),
285+
isArray: field.isList,
286+
type: this.getType(field.type),
287+
isRequired: !field.isNullable,
288+
attributes: [],
289+
};
290+
291+
if (field.isListNullable !== undefined) {
292+
fieldMeta.isArrayNullable = field.isListNullable;
293+
}
294+
295+
if (field.isReadOnly !== undefined) {
296+
fieldMeta.isReadOnly = field.isReadOnly;
297+
}
298+
299+
const association: AssociationType | void = this.getFieldAssociation(field);
300+
if (association) {
301+
fieldMeta.association = association;
302+
}
303+
acc[fieldMeta.name] = fieldMeta;
304+
return acc;
305+
}, {})
306+
}
307+
265308
private getType(gqlType: string): JSONModelFieldType {
266309
// Todo: Handle unlisted scalars
267310
if (gqlType in METADATA_SCALAR_MAP) {
@@ -273,6 +316,12 @@ export class AppSyncJSONVisitor<
273316
if (gqlType in this.nonModelMap) {
274317
return { nonModel: gqlType };
275318
}
319+
if (gqlType in this.interfaceMap) {
320+
return { interface: this.interfaceMap[gqlType].name };
321+
}
322+
if (gqlType in this.unionMap) {
323+
return { union: this.unionMap[gqlType].name };
324+
}
276325
if (gqlType in this.modelMap) {
277326
return { model: gqlType };
278327
}

‎packages/appsync-modelgen-plugin/src/visitors/appsync-typescript-visitor.ts‎

Lines changed: 38 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ import {
44
AppSyncModelVisitor,
55
CodeGenEnum,
66
CodeGenField,
7+
CodeGenInterface,
78
CodeGenModel,
89
CodeGenPrimaryKeyType,
10+
CodeGenUnion,
911
ParsedAppSyncModelConfig,
1012
RawAppSyncModelConfig,
1113
} from './appsync-visitor';
@@ -63,11 +65,19 @@ export class AppSyncModelTypeScriptVisitor<
6365
.map(typeObj => this.generateModelDeclaration(typeObj, true, false))
6466
.join('\n\n');
6567

68+
const unionDeclarations = Object.values(this.unionMap)
69+
.map(unionObj => this.generateUnionDeclaration(unionObj))
70+
.join('\n\n');
71+
72+
const interfaceDeclarations = Object.values(this.interfaceMap)
73+
.map(interfaceObj => this.generateInterfaceDeclaration(interfaceObj))
74+
.join('\n\n');
75+
6676
const modelInitialization = this.generateModelInitialization([...Object.values(this.modelMap), ...Object.values(this.nonModelMap)]);
6777

6878
const modelExports = this.generateExports(Object.values(this.modelMap));
6979

70-
return [imports, enumDeclarations, modelDeclarations, nonModelDeclarations, modelInitialization, modelExports].join('\n\n');
80+
return [imports, enumDeclarations, unionDeclarations, interfaceDeclarations, modelDeclarations, nonModelDeclarations, modelInitialization, modelExports].join('\n\n');
7181
}
7282

7383
protected generateImports(): string {
@@ -215,6 +225,26 @@ export class AppSyncModelTypeScriptVisitor<
215225
return [eagerModelDeclaration.string, lazyModelDeclaration.string, conditionalType, modelVariable].join('\n\n');
216226
}
217227

228+
protected generateInterfaceDeclaration(interfaceObj: CodeGenInterface): string {
229+
const declaration = new TypeScriptDeclarationBlock()
230+
.asKind('interface')
231+
.withName(interfaceObj.name)
232+
.export(true);
233+
234+
interfaceObj.fields.forEach(field => {
235+
declaration.addProperty(field.name, this.getNativeType(field), undefined, 'DEFAULT', {
236+
readonly: true,
237+
optional: field.isList ? field.isListNullable : field.isNullable,
238+
});
239+
});
240+
241+
return declaration.string;
242+
}
243+
244+
protected generateUnionDeclaration(unionObj: CodeGenUnion): string {
245+
return `export declare type ${unionObj.name} = ${unionObj.typeNames.join(' | ')};`;
246+
}
247+
218248
/**
219249
* Generate model Declaration using classCreator
220250
* @param model
@@ -242,15 +272,15 @@ export class AppSyncModelTypeScriptVisitor<
242272
return `${initializationResult.join(' ')};`;
243273
}
244274

245-
protected generateExports(modelsOrEnum: (CodeGenModel | CodeGenEnum)[]): string {
246-
const exportStr = modelsOrEnum
247-
.map(model => {
248-
if (model.type === 'model') {
249-
const modelClassName = this.generateModelImportAlias(model);
250-
const exportClassName = this.getModelName(model);
275+
protected generateExports(types: (CodeGenModel | CodeGenEnum | CodeGenInterface | CodeGenUnion)[]): string {
276+
const exportStr = types
277+
.map(type => {
278+
if (type.type === 'model') {
279+
const modelClassName = this.generateModelImportAlias(type);
280+
const exportClassName = this.getModelName(type);
251281
return modelClassName !== exportClassName ? `${modelClassName} as ${exportClassName}` : modelClassName;
252282
}
253-
return model.name;
283+
return type.name;
254284
})
255285
.join(',\n');
256286
return ['export {', indentMultiline(exportStr), '};'].join('\n');

‎packages/appsync-modelgen-plugin/src/visitors/appsync-visitor.ts‎

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,23 @@ export class AppSyncModelVisitor<
558558
}
559559
return this.enumMap;
560560
}
561+
562+
protected getSelectedUnions(): CodeGenUnionMap {
563+
if (this._parsedConfig.selectedType) {
564+
const selectedModel = this.unionMap[this._parsedConfig.selectedType];
565+
return selectedModel ? { [this._parsedConfig.selectedType]: selectedModel } : {};
566+
}
567+
return this.unionMap;
568+
}
569+
570+
protected getSelectedInterfaces(): CodeGenInterfaceMap {
571+
if (this._parsedConfig.selectedType) {
572+
const selectedModel = this.interfaceMap[this._parsedConfig.selectedType];
573+
return selectedModel ? { [this._parsedConfig.selectedType]: selectedModel } : {};
574+
}
575+
return this.interfaceMap;
576+
}
577+
561578
protected selectedTypeIsEnum() {
562579
if (this._parsedConfig && this._parsedConfig.selectedType) {
563580
if (this._parsedConfig.selectedType in this.enumMap) {
@@ -591,6 +608,10 @@ export class AppSyncModelVisitor<
591608
typeNameStr = this.getEnumName(this.enumMap[typeName]);
592609
} else if (this.isNonModelType(field)) {
593610
typeNameStr = this.getNonModelName(this.nonModelMap[typeName]);
611+
} else if (this.isUnionType(field)) {
612+
typeNameStr = this.getUnionName(this.unionMap[typeName]);
613+
} else if (this.isInterfaceType(field)) {
614+
typeNameStr = this.getInterfaceName(this.interfaceMap[typeName]);
594615
} else {
595616
throw new Error(`Unknown type ${typeName} for field ${field.name}. Did you forget to add the @model directive`);
596617
}
@@ -617,6 +638,14 @@ export class AppSyncModelVisitor<
617638
return model.name;
618639
}
619640

641+
protected getUnionName(union: CodeGenUnion) {
642+
return union.name;
643+
}
644+
645+
protected getInterfaceName(codeGenInterface: CodeGenInterface) {
646+
return codeGenInterface.name;
647+
}
648+
620649
protected getNonModelName(model: CodeGenModel) {
621650
return model.name;
622651
}
@@ -644,6 +673,16 @@ export class AppSyncModelVisitor<
644673
return typeName in this.nonModelMap;
645674
}
646675

676+
protected isUnionType(field: CodeGenField): boolean {
677+
const typeName = field.type;
678+
return typeName in this.unionMap;
679+
}
680+
681+
protected isInterfaceType(field: CodeGenField): boolean {
682+
const typeName = field.type;
683+
return typeName in this.interfaceMap;
684+
}
685+
647686
protected computeVersion(): string {
648687
// Sort types
649688
const typeArr: any[] = [];

0 commit comments

Comments
 (0)