Skip to content

Commit ea84908

Browse files
committed
fix: remove dup licenses acceptance (#933)
* fix: remove dup licenses acceptance * chore: add comments to clarify command behaviors * chore: add comment
1 parent 13d5951 commit ea84908

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.codebuild/run_android_modelgen_e2e_test.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,9 @@ phases:
1717
- yes | sudo apt install android-sdk
1818
- export ANDROID_HOME=/usr/lib/android-sdk
1919
- yes | sudo apt install sdkmanager
20-
# Review SDK licenses
21-
- yes | sudo sdkmanager --licenses
20+
# Licenses acceptance is needed for Android project build.
21+
# "sdkmanager --licenses" is handled in test beforeAll setup,
22+
# and this ensures the project accepts all licenses needed.
2223

2324
build:
2425
commands:

.codebuild/run_canary_android_modelgen_e2e_test.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ phases:
1515
- yes | sudo apt install android-sdk
1616
- export ANDROID_HOME=/usr/lib/android-sdk
1717
- yes | sudo apt install sdkmanager
18-
# Review SDK licenses
19-
- yes | sudo sdkmanager --licenses
18+
# Licenses acceptance is needed for Android project build.
19+
# "sdkmanager --licenses" is handled in test beforeAll setup,
20+
# and this ensures the project accepts all licenses needed.
2021

2122
build:
2223
commands:

packages/amplify-codegen-e2e-tests/src/__tests__/build-app-android.test.ts

+2
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ describe('build app - Android', () => {
3838
await addCodegen(projectRoot, {
3939
frontendType: AmplifyFrontend.android,
4040
});
41+
42+
// Required to accept all licenses needed per this test project build
4143
await acceptLicenses(projectRoot);
4244
});
4345

0 commit comments

Comments
 (0)