chore: update face fit instruction text and error message (#49)

phantumcode · web-flow · commit 680bb19835a9 · 2023-08-30T16:16:24.000-05:00
* chore: clean up face fit instruction text

* chore: update face fit instruction text and error message

* chore: update face fit instruction text and error message
diff --git a/HostApp/HostApp/Views/LivenessCheckErrorContentView.swift b/HostApp/HostApp/Views/LivenessCheckErrorContentView.swift
@@ -28,7 +28,7 @@ struct LivenessCheckErrorContentView: View {
 extension LivenessCheckErrorContentView {
     static let mock = LivenessCheckErrorContentView(
         name: "Time out",
-        description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face within 7 seconds."
+        description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face in it."
     )
 
     static let unexpected = LivenessCheckErrorContentView(
@@ -38,7 +38,7 @@ extension LivenessCheckErrorContentView {
 
     static let faceMatchTimeOut = LivenessCheckErrorContentView(
         name: "Time out",
-        description: "Face did not fill oval in time limit. Try again and completely fill the oval with face within 7 seconds."
+        description: "Face did not fill oval in time limit. Try again and completely fill the oval with face in it."
     )
 
     static let sessionTimeOut = LivenessCheckErrorContentView(
diff --git a/Sources/FaceLiveness/Resources/Base.lproj/Localizable.strings b/Sources/FaceLiveness/Resources/Base.lproj/Localizable.strings
@@ -15,7 +15,7 @@
 "amplify_ui_liveness_get_ready_steps_title" = "Follow the instructions to complete the check:";
 "amplify_ui_liveness_get_ready_face_not_covered" = "Make sure your face is not covered with sunglasses or a mask.";
 "amplify_ui_liveness_get_ready_lighting" = "Move to a well-lit place that is not in direct sunlight.";
-"amplify_ui_liveness_get_ready_fit_face" = "When an oval appears, fill the oval with your face within 7 seconds.";
+"amplify_ui_liveness_get_ready_fit_face" = "When an oval appears, fill the oval with your face in it.";
 "amplify_ui_liveness_get_ready_begin_check" = "Begin Check";
 "amplify_ui_liveness_get_ready_good_fit_example" = "Good fit";
 "amplify_ui_liveness_get_ready_too_far_example" = "Too far";
diff --git a/Sources/FaceLiveness/Utilities/LocalizedStringKey+Liveness.swift b/Sources/FaceLiveness/Utilities/LocalizedStringKey+Liveness.swift
@@ -58,7 +58,7 @@ extension LocalizedStringKey {
         "amplify_ui_liveness_get_ready_lighting"
     )
 
-    /// en = "When an oval appears, fill the oval with your face within 7 seconds."
+    /// en = "When an oval appears, fill the oval with your face in it."
     static let get_ready_fit_face = LocalizedStringKey(
         "amplify_ui_liveness_get_ready_fit_face"
     )
diff --git a/Tests/FaceLivenessTests/LivenessTests.swift b/Tests/FaceLivenessTests/LivenessTests.swift
@@ -140,7 +140,7 @@ final class FaceLivenessDetectionViewModelTestCase: XCTestCase {
     }
     
     /// Given:  A `FaceLivenessDetectionViewModel`
-    /// When: The viewModel handles a no fit event over a duration of 7 seconds
+    /// When: The viewModel handles a no fit event over a client default time limit of 7 seconds
     /// Then: The end state is `.encounteredUnrecoverableError(.timedOut)`
     func testNoFitTimeoutCheck() async throws {
         viewModel.livenessService = self.livenessService
diff --git a/Tests/IntegrationTestApp/IntegrationTestApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/Tests/IntegrationTestApp/IntegrationTestApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -5,26 +5,26 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/aws-amplify/amplify-swift",
       "state" : {
-        "revision" : "a01dfe5c0e5b38be13339a2005ce22874f5d4749",
-        "version" : "2.11.6"
+        "revision" : "90e7163cb7d1320ade541ec9b0029781d71a8a95",
+        "version" : "2.15.4"
       }
     },
     {
       "identity" : "amplify-swift-utils-notifications",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/aws-amplify/amplify-swift-utils-notifications.git",
       "state" : {
-        "revision" : "d4fd3c17e8d40efc821f448d3d6cff75b8f3b0dd",
-        "version" : "1.0.0"
+        "revision" : "f970384ad1035732f99259255cd2f97564807e41",
+        "version" : "1.1.0"
       }
     },
     {
       "identity" : "aws-appsync-realtime-client-ios",
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/aws-amplify/aws-appsync-realtime-client-ios.git",
       "state" : {
-        "revision" : "b036e83716789c13a3480eeb292b70caa54114f2",
-        "version" : "3.1.0"
+        "revision" : "c7ec93dcbbcd8abc90c74203937f207a7fcaa611",
+        "version" : "3.1.1"
       }
     },
     {
@@ -86,8 +86,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/apple/swift-log.git",
       "state" : {
-        "revision" : "32e8d724467f8fe623624570367e3d50c5638e46",
-        "version" : "1.5.2"
+        "revision" : "532d8b529501fb73a2455b179e0bbb6d49b652ed",
+        "version" : "1.5.3"
       }
     },
     {
diff --git a/Tests/IntegrationTestApp/IntegrationTestApp/Views/LivenessCheckErrorContentView.swift b/Tests/IntegrationTestApp/IntegrationTestApp/Views/LivenessCheckErrorContentView.swift
@@ -28,7 +28,7 @@ struct LivenessCheckErrorContentView: View {
 extension LivenessCheckErrorContentView {
     static let mock = LivenessCheckErrorContentView(
         name: "Time out",
-        description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face within 7 seconds."
+        description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face in it."
     )
 
     static let unexpected = LivenessCheckErrorContentView(
@@ -38,7 +38,7 @@ extension LivenessCheckErrorContentView {
 
     static let faceMatchTimeOut = LivenessCheckErrorContentView(
         name: "Time out",
-        description: "Face did not fill oval in time limit. Try again and completely fill the oval with face within 7 seconds."
+        description: "Face did not fill oval in time limit. Try again and completely fill the oval with face in it."
     )
 
     static let sessionTimeOut = LivenessCheckErrorContentView(

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ struct LivenessCheckErrorContentView: View {`
`28`	`28`	`extension LivenessCheckErrorContentView {`
`29`	`29`	`static let mock = LivenessCheckErrorContentView(`
`30`	`30`	`name: "Time out",`
`31`		`- description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face within 7 seconds."`
	`31`	`+ description: "Face didn't fit inside oval in time limit. Try again and completely fill the oval with face in it."`
`32`	`32`	`)`
`33`	`33`
`34`	`34`	`static let unexpected = LivenessCheckErrorContentView(`
`@@ -38,7 +38,7 @@ extension LivenessCheckErrorContentView {`
`38`	`38`
`39`	`39`	`static let faceMatchTimeOut = LivenessCheckErrorContentView(`
`40`	`40`	`name: "Time out",`
`41`		`- description: "Face did not fill oval in time limit. Try again and completely fill the oval with face within 7 seconds."`
	`41`	`+ description: "Face did not fill oval in time limit. Try again and completely fill the oval with face in it."`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`static let sessionTimeOut = LivenessCheckErrorContentView(`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ extension LocalizedStringKey {`
`58`	`58`	`"amplify_ui_liveness_get_ready_lighting"`
`59`	`59`	`)`
`60`	`60`
`61`		`- /// en = "When an oval appears, fill the oval with your face within 7 seconds."`
	`61`	`+ /// en = "When an oval appears, fill the oval with your face in it."`
`62`	`62`	`static let get_ready_fit_face = LocalizedStringKey(`
`63`	`63`	`"amplify_ui_liveness_get_ready_fit_face"`
`64`	`64`	`)`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ final class FaceLivenessDetectionViewModelTestCase: XCTestCase {`
`140`	`140`	`}`
`141`	`141`
`142`	`142`	/// Given: A `FaceLivenessDetectionViewModel`
`143`		`- /// When: The viewModel handles a no fit event over a duration of 7 seconds`
	`143`	`+ /// When: The viewModel handles a no fit event over a client default time limit of 7 seconds`
`144`	`144`	/// Then: The end state is `.encounteredUnrecoverableError(.timedOut)`
`145`	`145`	`func testNoFitTimeoutCheck() async throws {`
`146`	`146`	`viewModel.livenessService = self.livenessService`
Original file line number	Diff line number	Diff line change
`@@ -5,26 +5,26 @@`
`5`	`5`	`"kind" : "remoteSourceControl",`
`6`	`6`	`"location" : "https://github.com/aws-amplify/amplify-swift",`
`7`	`7`	`"state" : {`
`8`		`- "revision" : "a01dfe5c0e5b38be13339a2005ce22874f5d4749",`
`9`		`- "version" : "2.11.6"`
	`8`	`+ "revision" : "90e7163cb7d1320ade541ec9b0029781d71a8a95",`
	`9`	`+ "version" : "2.15.4"`
`10`	`10`	`}`
`11`	`11`	`},`
`12`	`12`	`{`
`13`	`13`	`"identity" : "amplify-swift-utils-notifications",`
`14`	`14`	`"kind" : "remoteSourceControl",`
`15`	`15`	`"location" : "https://github.com/aws-amplify/amplify-swift-utils-notifications.git",`
`16`	`16`	`"state" : {`
`17`		`- "revision" : "d4fd3c17e8d40efc821f448d3d6cff75b8f3b0dd",`
`18`		`- "version" : "1.0.0"`
	`17`	`+ "revision" : "f970384ad1035732f99259255cd2f97564807e41",`
	`18`	`+ "version" : "1.1.0"`
`19`	`19`	`}`
`20`	`20`	`},`
`21`	`21`	`{`
`22`	`22`	`"identity" : "aws-appsync-realtime-client-ios",`
`23`	`23`	`"kind" : "remoteSourceControl",`
`24`	`24`	`"location" : "https://github.com/aws-amplify/aws-appsync-realtime-client-ios.git",`
`25`	`25`	`"state" : {`
`26`		`- "revision" : "b036e83716789c13a3480eeb292b70caa54114f2",`
`27`		`- "version" : "3.1.0"`
	`26`	`+ "revision" : "c7ec93dcbbcd8abc90c74203937f207a7fcaa611",`
	`27`	`+ "version" : "3.1.1"`
`28`	`28`	`}`
`29`	`29`	`},`
`30`	`30`	`{`
`@@ -86,8 +86,8 @@`
`86`	`86`	`"kind" : "remoteSourceControl",`
`87`	`87`	`"location" : "https://github.com/apple/swift-log.git",`
`88`	`88`	`"state" : {`
`89`		`- "revision" : "32e8d724467f8fe623624570367e3d50c5638e46",`
`90`		`- "version" : "1.5.2"`
	`89`	`+ "revision" : "532d8b529501fb73a2455b179e0bbb6d49b652ed",`
	`90`	`+ "version" : "1.5.3"`
`91`	`91`	`}`
`92`	`92`	`},`
`93`	`93`	`{`