Skip to content

Commit 0058e77

Browse files
authored
fix(mobile-client): add missing userSub property to SignUpResult (#5125)
1 parent c484fff commit 0058e77

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

AWSAuthSDK/Sources/AWSMobileClient/AWSMobileClientOperations/AWSMobileClient+SignUp.swift

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,13 @@ extension AWSMobileClient {
9999
}
100100
}
101101
completionHandler(
102-
SignUpResult(signUpState: confirmedStatus!,
103-
codeDeliveryDetails: codeDeliveryDetails),
104-
nil)
102+
SignUpResult(
103+
signUpState: confirmedStatus!,
104+
codeDeliveryDetails: codeDeliveryDetails,
105+
userSub: result.userSub
106+
),
107+
nil
108+
)
105109
}
106110
return nil
107111
}
@@ -145,7 +149,7 @@ extension AWSMobileClient {
145149
if let error = task.error {
146150
completionHandler(nil, AWSMobileClientError.makeMobileClientError(from: error))
147151
} else if let _ = task.result {
148-
let signUpResult = SignUpResult(signUpState: .confirmed, codeDeliveryDetails: nil)
152+
let signUpResult = SignUpResult(signUpState: .confirmed, codeDeliveryDetails: nil, userSub: nil)
149153
completionHandler(signUpResult, nil)
150154
}
151155
return nil
@@ -186,7 +190,7 @@ extension AWSMobileClient {
186190
if let deliveryDetails = result.codeDeliveryDetails {
187191
codeDeliveryDetails = UserCodeDeliveryDetails.getUserCodeDeliveryDetails(deliveryDetails)
188192
}
189-
completionHandler(SignUpResult(signUpState: confirmedStatus, codeDeliveryDetails: codeDeliveryDetails), nil)
193+
completionHandler(SignUpResult(signUpState: confirmedStatus, codeDeliveryDetails: codeDeliveryDetails, userSub: nil), nil)
190194
}
191195
return nil
192196
})

AWSAuthSDK/Sources/AWSMobileClient/Models/SignUpResult.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,15 @@ import Foundation
1818
public struct SignUpResult {
1919
public let codeDeliveryDetails: UserCodeDeliveryDetails?
2020
public let signUpConfirmationState: SignUpConfirmationState
21+
public let userSub: String?
2122

22-
internal init(signUpState: SignUpConfirmationState, codeDeliveryDetails: UserCodeDeliveryDetails?){
23+
internal init(
24+
signUpState: SignUpConfirmationState,
25+
codeDeliveryDetails: UserCodeDeliveryDetails?,
26+
userSub: String?
27+
) {
2328
self.codeDeliveryDetails = codeDeliveryDetails
2429
self.signUpConfirmationState = signUpState
30+
self.userSub = userSub
2531
}
2632
}

AWSAuthSDK/Tests/AWSMobileClientTests/AWSMobileClientTestBase.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ class AWSMobileClientTestBase: XCTestCase {
194194
}
195195

196196
XCTAssertTrue(signUpResult.signUpConfirmationState == signupState, "User is expected to be marked as \(signupState).")
197-
197+
XCTAssertNotNil(signUpResult.userSub)
198198
signUpExpectation.fulfill()
199199
}
200200

0 commit comments

Comments
 (0)