Skip to content

Commit ecc70ba

Browse files
authored
Merge pull request #131 from michaelhtm/release-v1.4.2
Release artifacts for release v1.4.2
2 parents 97ca266 + fb99731 commit ecc70ba

File tree

5 files changed

+13
-14
lines changed

5 files changed

+13
-14
lines changed

config/controller/kustomization.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ kind: Kustomization
66
images:
77
- name: controller
88
newName: public.ecr.aws/aws-controllers-k8s/dynamodb-controller
9-
newTag: 1.4.1
9+
newTag: 1.4.2

helm/Chart.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
apiVersion: v1
22
name: dynamodb-chart
33
description: A Helm chart for the ACK service controller for Amazon DynamoDB (DynamoDB)
4-
version: 1.4.1
5-
appVersion: 1.4.1
4+
version: 1.4.2
5+
appVersion: 1.4.2
66
home: https://github.com/aws-controllers-k8s/dynamodb-controller
77
icon: https://raw.githubusercontent.com/aws/eks-charts/master/docs/logo/aws.png
88
sources:

helm/templates/NOTES.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{ .Chart.Name }} has been installed.
2-
This chart deploys "public.ecr.aws/aws-controllers-k8s/dynamodb-controller:1.4.1".
2+
This chart deploys "public.ecr.aws/aws-controllers-k8s/dynamodb-controller:1.4.2".
33

44
Check its status by running:
55
kubectl --namespace {{ .Release.Namespace }} get pods -l "app.kubernetes.io/instance={{ .Release.Name }}"

helm/values.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
image:
66
repository: public.ecr.aws/aws-controllers-k8s/dynamodb-controller
7-
tag: 1.4.1
7+
tag: 1.4.2
88
pullPolicy: IfNotPresent
99
pullSecrets: []
1010

pkg/resource/table/hooks.go

+8-9
Original file line numberDiff line numberDiff line change
@@ -614,15 +614,14 @@ func customPreCompare(
614614
// Making this field a no-op if user does not set it.
615615
// This will ensure controller does not act on this field
616616
// if user is unaware of it.
617-
if a.ko.Spec.ContributorInsights == nil {
618-
return
619-
}
620-
// latestInsight will always be either ENABLED or DISABLED, since we requeue at readOne if its not
621-
// either
622-
desiredInsight, _ := ensureContibutorInsight(a)
623-
latestInsight, _ := ensureContibutorInsight(b)
624-
if desiredInsight != latestInsight {
625-
delta.Add("Spec.ContributorInsights", a.ko.Spec.ContributorInsights, b.ko.Spec.ContributorInsights)
617+
if a.ko.Spec.ContributorInsights != nil {
618+
// latestInsight will always be either ENABLED or DISABLED, since we requeue at readOne if its not
619+
// either
620+
desiredInsight, _ := ensureContibutorInsight(a)
621+
latestInsight, _ := ensureContibutorInsight(b)
622+
if desiredInsight != latestInsight {
623+
delta.Add("Spec.ContributorInsights", a.ko.Spec.ContributorInsights, b.ko.Spec.ContributorInsights)
624+
}
626625
}
627626

628627
}

0 commit comments

Comments
 (0)