Fix for namespace creation and timer for Terratest (#465)

* helm create_namespace should always be false when irsa is enabled

* make false if create_namespace is not defined

* precommit format update

* 2 mins sleep added to aid tf destroy the cluster and vpc

* terraform-docs: automated action

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: vara-bonthu

examples/gitops/argocd/README.md

@@ -39,8 +39,9 @@
 |------|-------------|------|---------|:--------:|
 | <a name="input_cluster_version"></a> [cluster\_version](#input\_cluster\_version) | Kubernetes Version | `string` | `"1.21"` | no |
 | <a name="input_environment"></a> [environment](#input\_environment) | Environment area, e.g. prod or preprod | `string` | `"preprod"` | no |
+| <a name="input_region"></a> [region](#input\_region) | Region in which to deploy the cluster | `string` | `"us-west-2"` | no |
 | <a name="input_tenant"></a> [tenant](#input\_tenant) | Account Name or unique account unique id e.g., apps or management or aws007 | `string` | `"aws001"` | no |
-| <a name="input_zone"></a> [zone](#input\_zone) | zone, e.g. dev or qa or load or ops etc... | `string` | `"dev"` | no |
+| <a name="input_zone"></a> [zone](#input\_zone) | Zone, e.g. dev or qa or load or ops etc... | `string` | `"dev"` | no |
 
 ## Outputs
 

examples/gitops/argocd/variables.tf

@@ -26,4 +26,4 @@ variable "region" {
   type        = string
   description = "Region in which to deploy the cluster"
   default     = "us-west-2"
-}
+}

modules/kubernetes-addons/helm-addon/main.tf

@@ -6,7 +6,7 @@ resource "helm_release" "addon" {
   version                    = var.helm_config["version"]
   timeout                    = try(var.helm_config["timeout"], 300)
   values                     = try(var.helm_config["values"], null)
-  create_namespace           = try(var.helm_config["create_namespace"], false)
+  create_namespace           = var.irsa_config != null ? false : try(var.helm_config["create_namespace"], false)
   namespace                  = var.helm_config["namespace"]
   lint                       = try(var.helm_config["lint"], false)
   description                = try(var.helm_config["description"], "")

test/src/eks_blueprints_e2e_test.go

@@ -14,6 +14,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"strings"
 	"testing"
+	"time"
 )
 
 var (
@@ -148,6 +149,7 @@ func TestEksBlueprintsE2E(t *testing.T) {
 						}
 						terraformOptions := getTerraformOptions(t, destroyTFOptions)
 						terraform.Destroy(t, terraformOptions)
+						time.Sleep(2 * time.Minute) // Workaround for cleaning up dangling ENIs
 					} else {
 						terraformOptions := getTerraformOptions(t, inputTfOptions)
 						terraform.Destroy(t, terraformOptions)