From c6e03ab13d1e093ed6c7c296675b3e494b54ef13 Mon Sep 17 00:00:00 2001 From: Harry Date: Fri, 4 Oct 2024 16:00:54 -0700 Subject: [PATCH] Add Extra Unit Test for AwsMetricAttributeGenerator (#903) *Issue #, if available:* Adding extra unit test to check if leading whitespace in remote operation attributes are removed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --- .../providers/AwsMetricAttributeGeneratorTest.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java b/awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java index 9759753791..594d3f7dc9 100644 --- a/awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java +++ b/awsagentprovider/src/test/java/software/amazon/opentelemetry/javaagent/providers/AwsMetricAttributeGeneratorTest.java @@ -632,6 +632,19 @@ public void testGetDBStatementRemoteOperation() { mockAttribute(DB_STATEMENT, "SELECT FROM *"); mockAttribute(DB_OPERATION, "DB operation"); validateExpectedRemoteAttributes("DB system", "DB operation"); + + // Case 10: Duplicate of case 1 with leading whitespace + mockAttribute(DB_SYSTEM, "DB system"); + mockAttribute(DB_STATEMENT, " SELECT DB statement"); + mockAttribute(DB_OPERATION, null); + validateExpectedRemoteAttributes("DB system", "SELECT"); + + // Case 11: Duplicate of case 2 with leading whitespace. Test if whitespace affects longest + // match + mockAttribute(DB_SYSTEM, "DB system"); + mockAttribute(DB_STATEMENT, " DROP VIEW DB statement"); + mockAttribute(DB_OPERATION, null); + validateExpectedRemoteAttributes("DB system", "DROP VIEW"); } @Test