Testing lint checker

Author: Johnnyl202

aws-opentelemetry-distro/src/amazon/opentelemetry/distro/mcpinstrumentor/mcpinstrumentor.py

@@ -24,7 +24,7 @@ def setup_logger_two():
     return logger
 
 
-class MCPInstrumentor(BaseInstrumentor):
+class MCPInstrumentor(BaseInstrumentor):  # pylint: disable=attribute-defined-outside-init
     """
     An instrumenter for MCP.
     """
@@ -95,7 +95,7 @@ async def _wrap_handle_request(self, wrapped, instance, args, kwargs):
         else:
             return await wrapped(*args, **kwargs)
 
-    def _inject_trace_context(self, request_data, span_ctx):
+    def _inject_trace_context(self, request_data, span_ctx):  # pylint: disable=no-self-use
         if "params" not in request_data:
             request_data["params"] = {}
         if "_meta" not in request_data["params"]:
@@ -106,7 +106,7 @@ def _inject_trace_context(self, request_data, span_ctx):
         traceparent = f"00-{trace_id_hex}-{span_id_hex}-{trace_flags}"
         request_data["params"]["_meta"]["traceparent"] = traceparent
 
-    def _extract_span_context_from_traceparent(self, traceparent):
+    def _extract_span_context_from_traceparent(self, traceparent):  # pylint: disable=no-self-use
         parts = traceparent.split("-")
         if len(parts) == 4:
             try:
@@ -123,9 +123,9 @@ def _extract_span_context_from_traceparent(self, traceparent):
                 return None
         return None
 
-    def _get_span_name(self, req):
+    def _get_span_name(self, req):  # pylint: disable=no-self-use
         span_name = "unknown"
-        import mcp.types as types
+        import mcp.types as types  # pylint: disable=import-outside-toplevel
 
         if isinstance(req, types.ListToolsRequest):
             span_name = "tools/list"
@@ -137,7 +137,7 @@ def _get_span_name(self, req):
         return span_name
 
     def handle_attributes(self, span, request, is_client=True):
-        import mcp.types as types
+        import mcp.types as types  # pylint: disable=import-outside-toplevel
 
         operation = self._get_span_name(request)
         if isinstance(request, types.ListToolsRequest):
@@ -152,13 +152,13 @@ def handle_attributes(self, span, request, is_client=True):
         else:
             self._add_server_attributes(span, operation, request)
 
-    def _add_client_attributes(self, span, operation, request):
+    def _add_client_attributes(self, span, operation, request):  # pylint: disable=no-self-use
         span.set_attribute("aws.remote.service", "Appsignals MCP Server")
         span.set_attribute("aws.remote.operation", operation)
         if hasattr(request, "params") and hasattr(request.params, "name"):
             span.set_attribute("tool.name", request.params.name)
 
-    def _add_server_attributes(self, span, operation, request):
+    def _add_server_attributes(self, span, operation, request):  # pylint: disable=no-self-use
         span.set_attribute("server_side", True)
         if hasattr(request, "params") and hasattr(request.params, "name"):
             span.set_attribute("tool.name", request.params.name)

aws-opentelemetry-distro/tests/amazon/opentelemetry/distro/test_mcpinstrumentor.py

@@ -1,3 +1,6 @@
+# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+# SPDX-License-Identifier: Apache-2.0
+
 """
 Unit tests for MCPInstrumentor - testing actual mcpinstrumentor methods
 """
@@ -8,9 +11,12 @@
 import unittest
 from unittest.mock import MagicMock
 
+# Add src path for imports
 project_root = os.path.abspath(os.path.join(os.path.dirname(__file__), "../../../.."))
 src_path = os.path.join(project_root, "src")
 sys.path.insert(0, src_path)
+
+# pylint: disable=wrong-import-position
 from amazon.opentelemetry.distro.mcpinstrumentor.mcpinstrumentor import MCPInstrumentor  # noqa: E402
 
 
@@ -214,7 +220,7 @@ def setUp(self):
         mock_tracer = MagicMock()
         self.instrumentor.tracer = mock_tracer
 
-    def test_no_trace_context_fallback(self):
+    def test_no_trace_context_fallback(self):  # pylint: disable=no-self-use
         """Test graceful handling when no trace context is present on server side"""
 
         class MockServerNoTrace:
@@ -258,7 +264,7 @@ def __init__(self, name):
         # Should not create traced spans when no trace context is present
         mock_tracer.start_as_current_span.assert_not_called()
 
-    def test_end_to_end_client_server_communication(self):
+    def test_end_to_end_client_server_communication(self):  # pylint: disable=too-many-locals,too-many-statements
         """Test where server actually receives what client sends (including injected trace context)"""
 
         # Create realistic request/response classes