Renamed Method to ClearDefaultDimensions and removed the non default Dimensions from the clear method

Author: EgressGlynn

libraries/src/AWS.Lambda.Powertools.Metrics/IMetrics.cs

@@ -100,5 +100,5 @@ void PushSingleMetric(string metricName, double value, MetricUnit unit, string n
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    void ClearAllDimensions();
+    void ClearDefaultDimensions();
 }

libraries/src/AWS.Lambda.Powertools.Metrics/Metrics.cs

@@ -216,9 +216,9 @@ void IMetrics.Flush(bool metricsOverflow)
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    void IMetrics.ClearAllDimensions()
+    void IMetrics.ClearDefaultDimensions()
     {
-        _context.ClearAllDimensions();
+        _context.ClearDefaultDimensions();
     }
 
     /// <summary>
@@ -329,9 +329,9 @@ public static void SetDefaultDimensions(Dictionary<string, string> defaultDimens
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    public static void ClearAllDimensions()
+    public static void ClearDefaultDimensions()
     {
-        _instance.ClearAllDimensions();
+        _instance.ClearDefaultDimensions();
     }
 
     /// <summary>

libraries/src/AWS.Lambda.Powertools.Metrics/Model/Metadata.cs

@@ -179,8 +179,8 @@ internal Dictionary<string, string> ExpandAllDimensionSets()
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    internal void ClearAllDimensions()
+    internal void ClearDefaultDimensions()
     {
-        _metricDirective.ClearAllDimensions();
+        _metricDirective.ClearDefaultDimensions();
     }
 }

libraries/src/AWS.Lambda.Powertools.Metrics/Model/MetricDirective.cs

@@ -229,9 +229,8 @@ internal Dictionary<string, string> ExpandAllDimensionSets()
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    internal void ClearAllDimensions()
+    internal void ClearDefaultDimensions()
     {
-        Dimensions.Clear();
         DefaultDimensions.Clear();
     }
 }

libraries/src/AWS.Lambda.Powertools.Metrics/Model/MetricsContext.cs

@@ -166,8 +166,8 @@ public string Serialize()
     /// <summary>
     ///     Clears both default dimensions and dimensions lists
     /// </summary>
-    public void ClearAllDimensions()
+    public void ClearDefaultDimensions()
     {
-        _rootNode.AWS.ClearAllDimensions();
+        _rootNode.AWS.ClearDefaultDimensions();
     }
 }

libraries/tests/AWS.Lambda.Powertools.Metrics.Tests/ClearDimensionsTests.cs

@@ -35,7 +35,7 @@ public void WhenClearAllDimensions_NoDimensionsInOutput()
         // Act
         handler.OnEntry(eventArgs);
 
-        Metrics.ClearAllDimensions();
+        Metrics.ClearDefaultDimensions();
         Metrics.AddMetric($"Metric Name", 1, MetricUnit.Count);
 
         handler.OnExit(eventArgs);