Skip to content

Commit 3f2e7fe

Browse files
sdangolsvozza
andauthored
improv(maintenance): Removed some unused assignments and added missing error handling (#4208)
Co-authored-by: Stefano Vozza <[email protected]>
1 parent 1b779db commit 3f2e7fe

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

examples/snippets/parameters/testingYourCodeClientHandler.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@ export const handler = async (
1010
return {
1111
value: parameter,
1212
};
13-
} catch (_error) {
13+
} catch (error) {
14+
console.error('Unable to retrieve secret: ', error);
1415
return {
1516
message: 'Unable to retrieve secret',
1617
};

packages/parameters/tests/unit/BaseProvider.test.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -546,9 +546,6 @@ describe('Function: clearCaches', () => {
546546
describe('Class: GetOptions', () => {
547547
it('sets the default maxAge when not provided', () => {
548548
// Prepare
549-
const envVarsService = {
550-
getParametersMaxAge: vi.fn(),
551-
};
552549
const options = new GetOptions();
553550

554551
// Assess
@@ -559,9 +556,6 @@ describe('Class: GetOptions', () => {
559556
describe('Class: GetMultipleOptions', () => {
560557
it('sets throwOnTransformError to false when not provided', () => {
561558
// Prepare
562-
const envVarsService = {
563-
getParametersMaxAge: vi.fn(),
564-
};
565559
const options = new GetMultipleOptions();
566560

567561
// Assess

0 commit comments

Comments
 (0)