From 31d9c390a70cb1b8334a31ddb0ab477deada2b2e Mon Sep 17 00:00:00 2001 From: Henry Smith <36210679+hensmi-amazon@users.noreply.github.com> Date: Tue, 5 Mar 2024 15:27:15 -0800 Subject: [PATCH] Properly wrap 'setSinkId' in try/catch to fix firefox integ. test failures (#2852) --- demos/browser/app/meetingV2/meetingV2.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/demos/browser/app/meetingV2/meetingV2.ts b/demos/browser/app/meetingV2/meetingV2.ts index e8e724e4bd..b1212f9806 100644 --- a/demos/browser/app/meetingV2/meetingV2.ts +++ b/demos/browser/app/meetingV2/meetingV2.ts @@ -3009,8 +3009,12 @@ export class DemoMeetingApp // Set it for the content share stream if we can. const videoElem = document.getElementById('content-share-video') as HTMLVideoElement; if (this.defaultBrowserBehavior.supportsSetSinkId()) { - // @ts-ignore - videoElem.setSinkId(device); + try { + // @ts-ignore + await videoElem.setSinkId(device); + } catch (e) { + this.log('Failed to set audio output', e); + } } await this.audioVideo.chooseAudioOutput(device);