Skip to content

Commit 8ad5d83

Browse files
authored
fix docker login commands for gh actions (#65)
1 parent 78af685 commit 8ad5d83

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,14 @@ docker-run:
3737
docker run ${IMG_W_TAG}
3838

3939
docker-push:
40-
@echo ${DOCKERHUB_TOKEN} | docker login -u ${DOCKERHUB_USERNAME} --password-stdin
40+
@docker login -u ${DOCKERHUB_USERNAME} -p="${DOCKERHUB_TOKEN}"
4141
docker push ${IMG_W_TAG}
4242

4343
build-docker-images:
4444
${MAKEFILE_PATH}/scripts/build-docker-images -p ${SUPPORTED_PLATFORMS} -r ${IMG} -v ${VERSION}
4545

4646
push-docker-images:
47-
@echo ${DOCKERHUB_TOKEN} | docker login -u ${DOCKERHUB_USERNAME} --password-stdin
47+
@docker login -u ${DOCKERHUB_USERNAME} -p="${DOCKERHUB_TOKEN}"
4848
${MAKEFILE_PATH}/scripts/push-docker-images -p ${SUPPORTED_PLATFORMS} -r ${IMG} -v ${VERSION} -m
4949

5050
version:
@@ -136,4 +136,4 @@ release-prep-patch: create-local-release-tag-patch create-release-prep-pr
136136
release-prep-custom: # Run make NEW_VERSION=v1.2.3 release-prep-custom to prep for a custom release version
137137
ifdef NEW_VERSION
138138
$(shell echo "${MAKEFILE_PATH}/scripts/create-local-tag-for-release -v $(NEW_VERSION) && echo && make create-release-prep-pr")
139-
endif
139+
endif

0 commit comments

Comments
 (0)