Skip to content

Commit b4905ee

Browse files
committed
test(datashare): skip datashare tests for now
1 parent 77e420d commit b4905ee

File tree

2 files changed

+15
-26
lines changed

2 files changed

+15
-26
lines changed

test/integration/conftest.py

-14
Original file line numberDiff line numberDiff line change
@@ -39,20 +39,6 @@ def db_kwargs():
3939
return db_connect
4040

4141

42-
@pytest.fixture(scope="session")
43-
def datashare_db_kwargs():
44-
db_connect = {
45-
"database": conf.get("datashare-database", "database"),
46-
"host": conf.get("datashare-database", "host"),
47-
"user": conf.get("datashare-database", "user"),
48-
"password": conf.get("datashare-database", "password"),
49-
"ssl": conf.getboolean("datashare-database", "ssl"),
50-
"sslmode": conf.get("datashare-database", "sslmode"),
51-
}
52-
53-
return db_connect
54-
55-
5642
@pytest.fixture(scope="class")
5743
def okta_idp():
5844
db_connect = {

test/integration/metadata/test_list_catalog.py

+15-12
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,18 @@
4545

4646

4747
# @pytest.fixture(scope="session", autouse=True)
48-
# def list_catalog_config(request, datashare_db_kwargs):
48+
# def list_catalog_config(request, db_kwargs):
4949
# filterwarnings("ignore", "DB-API extension cursor.next()")
5050
# filterwarnings("ignore", "DB-API extension cursor.__iter__()")
51-
# with redshift_connector.connect(**datashare_db_kwargs) as con:
51+
# with redshift_connector.connect(**db_kwargs) as con:
5252
# con.paramstyle = "format"
5353
# with con.cursor() as cursor:
5454
# for stmt in startup_stmts:
5555
# cursor.execute(stmt)
5656
#
5757
# def fin():
5858
# try:
59-
# with redshift_connector.connect(**datashare_db_kwargs) as con:
59+
# with redshift_connector.connect(**db_kwargs) as con:
6060
# with con.cursor() as cursor:
6161
# for stmt in shutdown_stmts:
6262
# cursor.execute(stmt)
@@ -138,11 +138,12 @@ def get_schemas_test_data() -> typing.List[typing.Tuple[bool, typing.Dict[str, t
138138
return result
139139

140140

141+
@pytest.mark.skip(reason="manual")
141142
@pytest.mark.parametrize("_input", get_schemas_test_data())
142-
def test_get_schemas(mocker, _input, datashare_db_kwargs):
143+
def test_get_schemas(mocker, _input, db_kwargs):
143144
database_metadata_current_db_only_val, _args = _input
144-
datashare_db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
145-
with redshift_connector.connect(**datashare_db_kwargs) as conn:
145+
db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
146+
with redshift_connector.connect(**db_kwargs) as conn:
146147
assert conn.is_single_database_metadata is database_metadata_current_db_only_val
147148

148149
with conn.cursor() as cursor:
@@ -259,11 +260,12 @@ def get_tables_test_data() -> typing.List[typing.Tuple[bool, typing.Dict[str, ty
259260
return result
260261

261262

263+
@pytest.mark.skip(reason="manual")
262264
@pytest.mark.parametrize("_input", get_tables_test_data())
263-
def test_get_tables(mocker, _input, datashare_db_kwargs):
265+
def test_get_tables(mocker, _input, db_kwargs):
264266
database_metadata_current_db_only_val, _args = _input
265-
datashare_db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
266-
with redshift_connector.connect(**datashare_db_kwargs) as conn:
267+
db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
268+
with redshift_connector.connect(**db_kwargs) as conn:
267269
assert conn.is_single_database_metadata is database_metadata_current_db_only_val
268270

269271
with conn.cursor() as cursor:
@@ -468,11 +470,12 @@ def get_columns_test_data() -> typing.List[typing.Tuple[bool, typing.Dict[str, t
468470
return result
469471

470472

473+
@pytest.mark.skip(reason="manual")
471474
@pytest.mark.parametrize("_input", get_columns_test_data())
472-
def test_get_columns(mocker, _input, datashare_db_kwargs):
475+
def test_get_columns(mocker, _input, db_kwargs):
473476
database_metadata_current_db_only_val, _args = _input
474-
datashare_db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
475-
with redshift_connector.connect(**datashare_db_kwargs) as conn:
477+
db_kwargs["database_metadata_current_db_only"] = database_metadata_current_db_only_val
478+
with redshift_connector.connect(**db_kwargs) as conn:
476479
assert conn.is_single_database_metadata is database_metadata_current_db_only_val
477480

478481
with conn.cursor() as cursor:

0 commit comments

Comments
 (0)