Updated deployment setting file not exist check. Updated unit test to use error code instead of message.

Author: cresvi

src/AWS.Deploy.Common/Exceptions.cs

@@ -127,7 +127,7 @@ public enum DeployToolErrorCode
         UnsupportedOptionSettingType = 10010500,
         FailedToSaveDeploymentSettings = 10010600,
         InvalidWindowsManifestFile = 10010700,
-        DeploymentConfigurationNotFound = 10010800,
+        UserDeploymentFileNotFound = 10010800,
     }
 
     public class ProjectFileNotFoundException : DeployToolException

src/AWS.Deploy.Orchestration/DeploymentSettingsHandler.cs

@@ -52,19 +52,22 @@ public DeploymentSettingsHandler(IFileManager fileManager, IDirectoryManager dir
 
         public async Task<DeploymentSettings?> ReadSettings(string filePath)
         {
-            try
-            {
-                var contents = await _fileManager.ReadAllTextAsync(filePath);
-                var userDeploymentSettings = JsonConvert.DeserializeObject<DeploymentSettings>(contents);
-                return userDeploymentSettings;
-            }
-            catch (IOException ex)
-            {
-                throw new InvalidDeploymentSettingsException(DeployToolErrorCode.DeploymentConfigurationNotFound, $"An error occurred while trying to read the deployment settings file located at {filePath}. Make sure the path you provided exists on your file system, and is readable.", ex);
+            if (_fileManager.Exists(filePath))
+            {
+                try
+                {
+                    var contents = await _fileManager.ReadAllTextAsync(filePath);
+                    var userDeploymentSettings = JsonConvert.DeserializeObject<DeploymentSettings>(contents);
+                    return userDeploymentSettings;
+                }
+                catch (Exception ex)
+                {
+                    throw new InvalidDeploymentSettingsException(DeployToolErrorCode.FailedToDeserializeUserDeploymentFile, $"An error occurred while trying to deserialize the deployment settings file located at {filePath}.\n  {ex.Message}", ex);
+                }
             }
-            catch (Exception ex)
-            {
-                throw new InvalidDeploymentSettingsException(DeployToolErrorCode.FailedToDeserializeUserDeploymentFile, $"An error occurred while trying to deserialize the deployment settings file located at {filePath}.\n  {ex.Message}", ex);
+            else
+            {
+                throw new InvalidDeploymentSettingsException(DeployToolErrorCode.UserDeploymentFileNotFound, $"The deployment settings file located at {filePath} doesn't exist.");
             }
         }
 

test/AWS.Deploy.CLI.Common.UnitTests/ConfigFileDeployment/DeploymentSettingsHandlerTests.cs

@@ -259,7 +259,7 @@ public async Task ReadSettings_InvalidJson()
 
             // ASSERT
             var ex = await Assert.ThrowsAsync<InvalidDeploymentSettingsException>(readAction);
-            Assert.Contains("An error occurred while trying to deserialize the deployment settings file", ex.Message);
+            Assert.Equal(DeployToolErrorCode.FailedToDeserializeUserDeploymentFile, ex.ErrorCode);
         }
 
         [Fact]
@@ -275,7 +275,7 @@ public async Task ReadSettings_FileNotFound()
 
             // ASSERT
             var ex = await Assert.ThrowsAsync<InvalidDeploymentSettingsException>(readAction);
-            Assert.Contains("An error occurred while trying to read the deployment settings file", ex.Message);
+            Assert.Equal(DeployToolErrorCode.UserDeploymentFileNotFound, ex.ErrorCode);
         }
 
         private object GetOptionSettingValue(Recommendation recommendation, string fullyQualifiedId)