Skip to content

Commit 227c674

Browse files
authored
Make cert and key in MQTT5 pubsub sample optional (#596)
1 parent 49a4889 commit 227c674

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

samples/Utils/CommandLineUtils/utils/commandlineutils/CommandLineUtils.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -249,12 +249,18 @@ private void parseCommonMQTTCommands(SampleCommandLineData returnData) {
249249
returnData.input_ca = getCommandOrDefault(m_cmd_ca_file, "");
250250
}
251251

252-
private void parseKeyAndCertCommands(SampleCommandLineData returnData)
252+
private void parseKeyAndCertCommandsRequired(SampleCommandLineData returnData)
253253
{
254254
returnData.input_cert = getCommandRequired(m_cmd_cert_file);
255255
returnData.input_key = getCommandRequired(m_cmd_key_file);
256256
}
257257

258+
private void parseKeyAndCertCommandsOptional(SampleCommandLineData returnData)
259+
{
260+
returnData.input_cert = getCommandOrDefault(m_cmd_cert_file, "");
261+
returnData.input_key = getCommandOrDefault(m_cmd_key_file, "");
262+
}
263+
258264
private void parseClientIdAndPort(SampleCommandLineData returnData) {
259265
returnData.input_clientId = getCommandOrDefault(m_cmd_client_id, "test-" + UUID.randomUUID().toString());
260266
returnData.input_port = Integer.parseInt(getCommandOrDefault(m_cmd_port, "8883"));
@@ -385,7 +391,7 @@ public SampleCommandLineData parseSampleInputBasicConnect(String[] args)
385391
parseCommonLoggingCommands(returnData);
386392
parseCommonMQTTCommands(returnData);
387393
parseCommonProxyCommands(returnData);
388-
parseKeyAndCertCommands(returnData);
394+
parseKeyAndCertCommandsRequired(returnData);
389395
parseClientIdAndPort(returnData);
390396
return returnData;
391397
}
@@ -403,7 +409,7 @@ public SampleCommandLineData parseSampleInputPubSub(String [] args)
403409
SampleCommandLineData returnData = new SampleCommandLineData();
404410
parseCommonLoggingCommands(returnData);
405411
parseCommonMQTTCommands(returnData);
406-
parseKeyAndCertCommands(returnData);
412+
parseKeyAndCertCommandsRequired(returnData);
407413
parseCommonTopicMessageCommands(returnData);
408414
parseCommonProxyCommands(returnData);
409415
parseClientIdAndPort(returnData);
@@ -465,7 +471,7 @@ public SampleCommandLineData parseSampleInputCustomKeyOpsConnect(String [] args)
465471
SampleCommandLineData returnData = new SampleCommandLineData();
466472
parseCommonLoggingCommands(returnData);
467473
parseCommonMQTTCommands(returnData);
468-
parseKeyAndCertCommands(returnData);
474+
parseKeyAndCertCommandsRequired(returnData);
469475
parseClientIdAndPort(returnData);
470476
return returnData;
471477
}
@@ -499,7 +505,7 @@ public SampleCommandLineData parseSampleInputFleetProvisioning(String [] args)
499505
parseMqttVersion(returnData);
500506
parseCommonLoggingCommands(returnData);
501507
parseCommonMQTTCommands(returnData);
502-
parseKeyAndCertCommands(returnData);
508+
parseKeyAndCertCommandsRequired(returnData);
503509
parseClientIdAndPort(returnData);
504510
returnData.input_templateName = getCommandRequired(m_cmd_fleet_template_name);
505511
returnData.input_templateParameters = getCommandRequired(m_cmd_fleet_template_parameters);
@@ -523,7 +529,7 @@ public SampleCommandLineData parseSampleInputGreengrassDiscovery(String [] args)
523529

524530
SampleCommandLineData returnData = new SampleCommandLineData();
525531
parseCommonLoggingCommands(returnData);
526-
parseKeyAndCertCommands(returnData);
532+
parseKeyAndCertCommandsRequired(returnData);
527533
returnData.input_ca = getCommandOrDefault(m_cmd_ca_file, null);
528534
returnData.input_thingName = getCommandRequired(m_cmd_thing_name);
529535
returnData.input_signingRegion = getCommandRequired(m_cmd_region, m_cmd_signing_region);
@@ -574,7 +580,7 @@ public SampleCommandLineData parseSampleInputJobs(String[] args)
574580
parseMqttVersion(returnData);
575581
parseCommonLoggingCommands(returnData);
576582
parseCommonMQTTCommands(returnData);
577-
parseKeyAndCertCommands(returnData);
583+
parseKeyAndCertCommandsRequired(returnData);
578584
parseClientIdAndPort(returnData);
579585
returnData.input_thingName = getCommandRequired(m_cmd_thing_name);
580586
return returnData;
@@ -595,7 +601,7 @@ public SampleCommandLineData parseSampleInputMqtt5PubSub(String [] args)
595601
parseCommonLoggingCommands(returnData);
596602
parseCommonMQTTCommands(returnData);
597603
parseCommonTopicMessageCommands(returnData);
598-
parseKeyAndCertCommands(returnData);
604+
parseKeyAndCertCommandsOptional(returnData);
599605
parseCommonProxyCommands(returnData);
600606
parseClientIdAndPort(returnData);
601607
returnData.input_signingRegion = getCommandOrDefault(m_cmd_signing_region, null);
@@ -617,7 +623,7 @@ public SampleCommandLineData parseSampleInputMqtt5SharedSubscription(String [] a
617623
parseCommonLoggingCommands(returnData);
618624
parseCommonMQTTCommands(returnData);
619625
parseCommonTopicMessageCommands(returnData);
620-
parseKeyAndCertCommands(returnData);
626+
parseKeyAndCertCommandsRequired(returnData);
621627
parseCommonProxyCommands(returnData);
622628
parseClientIdAndPort(returnData);
623629
returnData.input_groupIdentifier = getCommandOrDefault(m_cmd_group_identifier, "java-sample");
@@ -669,7 +675,7 @@ public SampleCommandLineData parseSampleInputShadow(String [] args)
669675
parseMqttVersion(returnData);
670676
parseCommonLoggingCommands(returnData);
671677
parseCommonMQTTCommands(returnData);
672-
parseKeyAndCertCommands(returnData);
678+
parseKeyAndCertCommandsRequired(returnData);
673679
parseClientIdAndPort(returnData);
674680
returnData.input_thingName = getCommandRequired(m_cmd_thing_name);
675681
returnData.input_shadowProperty = getCommand(m_cmd_shadow_property);

0 commit comments

Comments
 (0)