Skip to content

Commit 1d061f4

Browse files
authoredJun 19, 2024··
[153] Have PR workflow run against all OSes (#154)
Mirrors the structure of the NodeJS ric with respect to github actions to run integ tests against all vendors. Issues with particular vendors won't be fixed in this PR to keep it short. Drops: python 3.7 in all but al1
1 parent 3a7d01e commit 1d061f4

File tree

7 files changed

+49
-14
lines changed

7 files changed

+49
-14
lines changed
 

Diff for: ‎.github/workflows/test-on-push-and-pr.yml

+40-6
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,45 @@ jobs:
1212

1313
steps:
1414
- uses: actions/checkout@v2
15-
env:
16-
GITHUB_WORKSPACE: /
17-
- name: Set up python
18-
uses: actions/setup-python@v2
19-
with:
20-
python-version: '3.8'
2115
- name: Run 'pr' target
2216
run: make pr
17+
18+
alpine:
19+
runs-on: ubuntu-latest
20+
21+
steps:
22+
- uses: actions/checkout@v2
23+
- name: Run alpine integration tests
24+
run: DISTRO=alpine make test-integ
25+
26+
amazonlinux:
27+
runs-on: ubuntu-latest
28+
29+
steps:
30+
- uses: actions/checkout@v2
31+
- name: Run amazonlinux integration tests
32+
run: DISTRO=amazonlinux make test-integ
33+
34+
centos:
35+
runs-on: ubuntu-latest
36+
37+
steps:
38+
- uses: actions/checkout@v2
39+
- name: Run centos integration tests
40+
run: DISTRO=centos make test-integ
41+
42+
debian:
43+
runs-on: ubuntu-latest
44+
45+
steps:
46+
- uses: actions/checkout@v2
47+
- name: Run debian integration tests
48+
run: DISTRO=debian make test-integ
49+
50+
ubuntu:
51+
runs-on: ubuntu-latest
52+
53+
steps:
54+
- uses: actions/checkout@v2
55+
- name: Run ubuntu integration tests
56+
run: DISTRO=ubuntu make test-integ

Diff for: ‎Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ test-smoke: setup-codebuild-agent
2121

2222
.PHONY: test-integ
2323
test-integ: setup-codebuild-agent
24-
CODEBUILD_IMAGE_TAG=codebuild-agent tests/integration/codebuild-local/test_all.sh tests/integration/codebuild/.
24+
CODEBUILD_IMAGE_TAG=codebuild-agent DISTRO="$(DISTRO)" tests/integration/codebuild-local/test_all.sh tests/integration/codebuild/.
2525

2626
.PHONY: check-security
2727
check-security:
@@ -41,7 +41,9 @@ dev: init test
4141

4242
# Verifications to run before sending a pull request
4343
.PHONY: pr
44-
pr: init check-format check-security dev test-smoke
44+
pr: init check-format check-security dev setup-codebuild-agent
45+
CODEBUILD_IMAGE_TAG=codebuild-agent DISTRO="$(DISTRO)" tests/integration/codebuild-local/test_all.sh tests/integration/codebuild
46+
4547

4648
.PHONY: clean
4749
clean:

Diff for: ‎tests/integration/codebuild-local/test_all.sh

+5-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ set -euo pipefail
55

66
CODEBUILD_IMAGE_TAG="${CODEBUILD_IMAGE_TAG:-al2/x86_64/standard/3.0}"
77
DRYRUN="${DRYRUN-0}"
8+
DISTRO="${DISTRO:=""}"
89

910
function usage {
1011
echo "usage: test_all.sh buildspec_yml_dir"
@@ -51,10 +52,12 @@ main() {
5152
usage
5253
exit 1
5354
fi
54-
55+
5556
BUILDSPEC_YML_DIR="$1"
57+
echo $DISTRO $BUILDSPEC_YML_DIR
58+
ls $BUILDSPEC_YML_DIR
5659
HAS_YML=0
57-
for f in "$BUILDSPEC_YML_DIR"/*.yml ; do
60+
for f in "$BUILDSPEC_YML_DIR"/*"$DISTRO"*.yml ; do
5861
[ -f "$f" ] || continue;
5962
do_one_yaml "$f"
6063
HAS_YML=1

Diff for: ‎tests/integration/codebuild/buildspec.os.alpine.yml

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ batch:
1919
- "3.14"
2020
- "3.15"
2121
RUNTIME_VERSION:
22-
- "3.7"
2322
- "3.8"
2423
- "3.9"
2524
- "3.10"

Diff for: ‎tests/integration/codebuild/buildspec.os.centos.yml

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ batch:
1717
DISTRO_VERSION:
1818
- "7"
1919
RUNTIME_VERSION:
20-
- "3.7"
2120
- "3.8"
2221
- "3.9"
2322
- "3.10"

Diff for: ‎tests/integration/codebuild/buildspec.os.debian.yml

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ batch:
1818
- "buster"
1919
- "bullseye"
2020
RUNTIME_VERSION:
21-
- "3.7"
2221
- "3.8"
2322
- "3.9"
2423
- "3.10"

Diff for: ‎tests/integration/codebuild/buildspec.os.ubuntu.yml

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ batch:
1818
- "20.04"
1919
- "22.04"
2020
RUNTIME_VERSION:
21-
- "3.7"
2221
- "3.8"
2322
- "3.9"
2423
- "3.10"

0 commit comments

Comments
 (0)
Please sign in to comment.