[Test] Add integ test to capture fragilities in cluster update workflow#7275
Open
gmarciani wants to merge 4 commits intoaws:developfrom
Open
[Test] Add integ test to capture fragilities in cluster update workflow#7275gmarciani wants to merge 4 commits intoaws:developfrom
gmarciani wants to merge 4 commits intoaws:developfrom
Conversation
d9050f3 to
82904c3
Compare
82904c3 to
9a9da62
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7275 +/- ##
===========================================
+ Coverage 90.06% 90.08% +0.01%
===========================================
Files 182 182
Lines 16646 16730 +84
===========================================
+ Hits 14992 15071 +79
- Misses 1654 1659 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d6f88e3 to
7f56e41
Compare
b293f22 to
82b0e94
Compare
Comment on lines
+336
to
+348
| # def pytest_collection_finish(session): | ||
| # _log_collected_tests(session) | ||
| # # Create the metadata table after the regions are collected | ||
| # try: | ||
| # region = session.config.getoption("regions") or get_all_regions(session.config.getoption("tests_config")) | ||
| # region = [unmarshal_az_override(az) for az in region] | ||
| # # Use the first element of the list of regions, since there must be at least one | ||
| # reporting_region = get_reporting_region(region[0]) | ||
| # logging.info(f"Metadata reporting region {reporting_region}") | ||
| # # Setup the metadata table in case it doesn't exist | ||
| # MetadataTableManager(reporting_region, METADATA_TABLE).create_metadata_table() | ||
| # except Exception as exc: | ||
| # logging.info(f"There was a '{type(exc)}' error with '{exc}' when creating the table!") |
Check notice
Code scanning / CodeQL
Commented-out code Note test
Contributor
Author
There was a problem hiding this comment.
This commit is just for testing and will be removed
d3540d1 to
687a4c2
Compare
687a4c2 to
945feaa
Compare
8d3ca25 to
52c7820
Compare
967f42e to
7c82713
Compare
7c82713 to
8640080
Compare
537bd87 to
3acdb21
Compare
71688eb to
be457d0
Compare
b7ed825 to
e1a5d8c
Compare
e1a5d8c to
757ad82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add end to end test to capture fragilities in cluster update workflow.
The test validates the following scenarios:
Auxiliary changes to common functions:
Tests
PENDING
test_update_race_conditionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.