Skip to content

Commit f51df59

Browse files
Fix TSan report around condvar in host resolver (#3013)
* Fix TSan report around condvar in host resolver * Update GeneralHTTPCredentialsProvider.cpp
1 parent ff61797 commit f51df59

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/aws-cpp-sdk-core/source/auth/GeneralHTTPCredentialsProvider.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,13 @@ bool GeneralHTTPCredentialsProvider::ShouldCreateGeneralHTTPProvider(const Aws::
120120
std::unique_lock<std::mutex> lock(hostResolverMutex);
121121
shouldAllow = !addresses.empty();
122122
hostResolved = true;
123+
hostResolverCV.notify_one();
124+
}
125+
else
126+
{
127+
std::unique_lock<std::mutex> lock(hostResolverMutex);
128+
hostResolverCV.notify_one();
123129
}
124-
hostResolverCV.notify_one();
125130
};
126131
pHostResolver->ResolveHost(authority.c_str(), onHostResolved);
127132
std::unique_lock<std::mutex> lock(hostResolverMutex);

0 commit comments

Comments
 (0)