Update rewrite versions at build time (#5931)

* Update rewrite versions at build time

This change changes add-transfer-manager-dependency.yml and
upgrade-sdk-dependencies.yml to velocity templates so that the version
number can be set at build time when buliding the v2-migration module.
This moves this version update process out of the buildspecs so that we
don't have to rely on them to have been run for builds to work
correctly.

* Move version to a property

Author: dagnir

buildspecs/update-master-from-release.yml

@@ -40,9 +40,6 @@ phases:
         mvn versions:set -DnewVersion=$NEW_VERSION_SNAPSHOT -DgenerateBackupPoms=false -DprocessAllModules=true || { echo "Failed to update POMs to next snapshot version"; exit 1; }
         sed -i -E "s/(<version>).+(<\/version>)/\1$RELEASE_VERSION\2/" README.md
         sed -i -E "s/(<awsjavasdk.previous.version>).+(<\/awsjavasdk.previous.version>)/\1$RELEASE_VERSION\2/" pom.xml
-        sed -i -E "s/(newVersion: ).+/\1$RELEASE_VERSION/" v2-migration/src/main/resources/META-INF/rewrite/upgrade-sdk-dependencies.yml
-        sed -i -E "s/(version: ).+/\1$RELEASE_VERSION/" v2-migration/src/main/resources/META-INF/rewrite/upgrade-sdk-dependencies.yml
-        sed -i -E "s/(version: ).+/\1$RELEASE_VERSION/" v2-migration/src/main/resources/META-INF/rewrite/add-transfer-manager-dependency.yml
       
         git commit -am "Update to next snapshot version: $NEW_VERSION_SNAPSHOT"
       fi

core/sdk-core/pom.xml

@@ -266,7 +266,7 @@
             <plugin>
                 <groupId>com.nativelibs4java</groupId>
                 <artifactId>maven-velocity-plugin</artifactId>
-                <version>0.9</version>
+                <version>${maven-velocity-plugin.version}</version>
                 <executions>
                     <execution>
                         <phase>generate-sources</phase>

pom.xml

@@ -169,6 +169,7 @@
         <!-- Whenever we update maven-wrapper-plugin version, we need to run mvn wrapper:wrapper to update the Maven Wrapper files(mvnw, .maven and mvnw.cmd) -->
         <maven-wrapper-plugin.version>3.2.0</maven-wrapper-plugin.version>
         <ant.version>1.10.14</ant.version>
+        <maven-velocity-plugin.version>0.9</maven-velocity-plugin.version>
 
         <!-- These properties are used by Step functions for its dependencies -->
         <json-path.version>2.4.0</json-path.version>

v2-migration/pom.xml

@@ -287,6 +287,26 @@
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>com.nativelibs4java</groupId>
+                <artifactId>maven-velocity-plugin</artifactId>
+                <version>${maven-velocity-plugin.version}</version>
+                <executions>
+                    <execution>
+                        <phase>generate-sources</phase>
+                        <goals>
+                            <goal>generate</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <configuration>
+                    <velocitySources>src/main/resources/recipe-vm-templates</velocitySources>
+                    <resourcesOutputDirectory>${project.build.directory}/classes/META-INF/rewrite</resourcesOutputDirectory>
+                    <properties>
+                        <sdkVersion>${awsjavasdk.previous.version}</sdkVersion>
+                    </properties>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>

v2-migration/src/main/resources/META-INF/rewrite/add-transfer-manager-dependency.yml renamed to v2-migration/src/main/resources/recipe-vm-templates/add-transfer-manager-dependency.yml.vm

@@ -24,5 +24,5 @@ recipeList:
   - org.openrewrite.java.dependencies.AddDependency:
       groupId: software.amazon.awssdk
       artifactId: s3-transfer-manager
-      version: 2.30.38
-      onlyIfUsing: com.amazonaws.services.s3.transfer.TransferManager
+      version: ${sdkVersion}
+      onlyIfUsing: com.amazonaws.services.s3.transfer.TransferManager