Skip to content

Method fromInputStream doesn't buffer anymore #6038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Aleksei-Kolebakin opened this issue Apr 16, 2025 · 2 comments · Fixed by #6046
Closed

Method fromInputStream doesn't buffer anymore #6038

Aleksei-Kolebakin opened this issue Apr 16, 2025 · 2 comments · Fixed by #6046
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue

Comments

@Aleksei-Kolebakin
Copy link

Describe the issue

In the 2.30.17 version buffering was removed in the public static RequestBody fromInputStream(InputStream inputStream, long contentLength) method. But documentation for this method still contains this note:
Important: If inputStream does not support mark and reset, the stream will be buffered.
Link to the PR:
5f2af77#diff-1a88bd363dd55e33ebf3734f8a96c524d600b3f46745c82169482718d43c030a
Link to the documentation: https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/sync/RequestBody.html#fromInputStream(java.io.InputStream,long)

Links

https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/sync/RequestBody.html#fromInputStream(java.io.InputStream,long)
@Aleksei-Kolebakin Aleksei-Kolebakin added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2025
@bhoradc
Copy link

bhoradc commented Apr 16, 2025

Hi @Aleksei-Kolebakin,

Thank you for reporting the documentation discrepancy. We are looking into this, shall keep you posted.

Regards,
Chaitanya

@bhoradc bhoradc added p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2025
@RanVaknin RanVaknin mentioned this issue Apr 18, 2025
Merged
@github-actions GitHub Actions
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated buffering note in RequestBody.fromInputStream aws/aws-sdk-java-v2
2 participants
@bhoradc @Aleksei-Kolebakin