Skip to content

Commit 8965bdb

Browse files
stevenawdscpinheiro
authored andcommitted
Remove a few duplicate lookups
1 parent a4e2880 commit 8965bdb

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

sdk/src/Core/Amazon.Runtime/Internal/Auth/AWS4Signer.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -280,10 +280,9 @@ private static void CleanHeaders(IDictionary<string, string> headers)
280280
headers.Remove(HeaderKeys.AuthorizationHeader);
281281
headers.Remove(HeaderKeys.XAmzContentSha256Header);
282282

283-
if (headers.ContainsKey(HeaderKeys.XAmzDecodedContentLengthHeader))
283+
if (headers.TryGetValue(HeaderKeys.XAmzDecodedContentLengthHeader, out string decodedContentLength))
284284
{
285-
headers[HeaderKeys.ContentLengthHeader] =
286-
headers[HeaderKeys.XAmzDecodedContentLengthHeader];
285+
headers[HeaderKeys.ContentLengthHeader] = decodedContentLength;
287286
headers.Remove(HeaderKeys.XAmzDecodedContentLengthHeader);
288287
}
289288
}
@@ -507,13 +506,13 @@ public static string SetRequestBodyHash(IRequest request, bool signPayload, stri
507506
{
508507
computedContentHash = chunkedBodyHash;
509508

510-
if (request.Headers.ContainsKey(HeaderKeys.ContentLengthHeader))
509+
if (request.Headers.TryGetValue(HeaderKeys.ContentLengthHeader, out string contentLength))
511510
{
512511
// Set X-Amz-Decoded-Content-Length with the true size of the data
513-
request.Headers[HeaderKeys.XAmzDecodedContentLengthHeader] = request.Headers[HeaderKeys.ContentLengthHeader];
512+
request.Headers[HeaderKeys.XAmzDecodedContentLengthHeader] = contentLength;
514513

515514
// Substitute the originally declared content length with the inflated length due to chunking metadata and/or trailing headers
516-
var originalContentLength = long.Parse(request.Headers[HeaderKeys.ContentLengthHeader], CultureInfo.InvariantCulture);
515+
var originalContentLength = long.Parse(contentLength, CultureInfo.InvariantCulture);
517516
request.Headers[HeaderKeys.ContentLengthHeader]
518517
= ChunkedUploadWrapperStream.ComputeChunkedContentLength(originalContentLength, signatureLength, request.TrailingHeaders, request.SelectedChecksum).ToString(CultureInfo.InvariantCulture);
519518
}

sdk/src/Services/S3/Custom/Util/AmazonS3Util.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,9 @@ public static partial class AmazonS3Util
231231
/// <returns>The MIME type for the extension, or text/plain</returns>
232232
public static string MimeTypeFromExtension(string ext)
233233
{
234-
if (extensionToMime.ContainsKey(ext))
234+
if (extensionToMime.TryGetValue(ext, out string mimeType))
235235
{
236-
return extensionToMime[ext];
236+
return mimeType;
237237
}
238238
else
239239
{

0 commit comments

Comments
 (0)